New issue
Advanced search Search tips

Issue 920218 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Remove SigninManager-related includes from advanced_protection_status_manager_factory.cc

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Look unused.
 
Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51ae1bd6c53c01822a9da2e8032009821175d662

commit 51ae1bd6c53c01822a9da2e8032009821175d662
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Jan 18 07:31:27 2019

[s13n] Remove unused header from advanced_protection_status_manager_factory.cc

This CL remove unused header, signin_manager.h.

Bug:  920218 
TBR: vakh@chromium.org
Change-Id: I87dafb83f38d164de68baf12e7f40fc30446e97a
Reviewed-on: https://chromium-review.googlesource.com/c/1411472
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624029}
[modify] https://crrev.com/51ae1bd6c53c01822a9da2e8032009821175d662/chrome/browser/safe_browsing/advanced_protection_status_manager_factory.cc

Comment 3 by je_julie.kim@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment