Findit identified the culprit r621134 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDBiMzBiMmZlMzM5NmQ0Y2E3NmUzNDhmMGEzOWVhNzRhOGFkMmI5OAw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r621134&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDBiMzBiMmZlMzM5NmQ0Y2E3NmUzNDhmMGEzOWVhNzRhOGFkMmI5OAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b046c87b8bf8cee36873b9ccb917a5195fbe92e commit 1b046c87b8bf8cee36873b9ccb917a5195fbe92e Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Jan 09 15:23:22 2019 Revert "sync_integration_tests: don't instantiate ScopedFeatureList in test body" This reverts commit d0b30b2fe3396d4ca76e348f0a39ea74a8ad2b98. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 621134 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDBiMzBiMmZlMzM5NmQ0Y2E3NmUzNDhmMGEzOWVhNzRhOGFkMmI5OAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/32338 Sample Failed Step: sync_integration_tests Sample Flaky Test: SingleClientWalletWithAccountStorageSyncTest.DownloadAccountStorage_Card Original change's description: > sync_integration_tests: don't instantiate ScopedFeatureList in test body > > Creating a ScopedFeatureList instance in the test body creates a data > race related to the global FeatureList instance: The ScopedFeatureList > overrides the global instance, and then it gets reset after the test > body; however, the feature list might still be queried from the Sync > thread after that. > > This CL avoids the issue by instead creating test (sub)classes to hold > the ScopedFeatureLists. > > Bug: 915219 > Change-Id: Ib1e0d87ed4ecc5ef33e9601ba84efecd399fb003 > Reviewed-on: https://chromium-review.googlesource.com/c/1402799 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621134} Change-Id: Ic97b93a8c18d4db22ed92aaabb33074a0862c3ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 915219 , 920216 Reviewed-on: https://chromium-review.googlesource.com/c/1403080 Cr-Commit-Position: refs/heads/master@{#621146} [modify] https://crrev.com/1b046c87b8bf8cee36873b9ccb917a5195fbe92e/chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc [modify] https://crrev.com/1b046c87b8bf8cee36873b9ccb917a5195fbe92e/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc [modify] https://crrev.com/1b046c87b8bf8cee36873b9ccb917a5195fbe92e/chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc [modify] https://crrev.com/1b046c87b8bf8cee36873b9ccb917a5195fbe92e/chrome/browser/sync/test/integration/single_client_user_consents_sync_test.cc [modify] https://crrev.com/1b046c87b8bf8cee36873b9ccb917a5195fbe92e/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
Argh, what happened here is that the test in question was already very flaky on TSan [1]. This CL changed the test name, so Findit detected it as new flakiness. I'll disable the test on TSan and then reland. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=DownloadAccountStorage_Card
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b281f3aed18f7d936ba30ad8e21f45762a824c commit 85b281f3aed18f7d936ba30ad8e21f45762a824c Author: Marc Treib <treib@chromium.org> Date: Wed Jan 09 16:22:50 2019 Disable SingleClientWalletSyncTest.DownloadAccountStorage_Card on TSan It's very flaky. Bug: 917385 , 920216 Change-Id: I74cb81327872f5d6d909e3e7d274e65479674d3b Reviewed-on: https://chromium-review.googlesource.com/c/1402887 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621168} [modify] https://crrev.com/85b281f3aed18f7d936ba30ad8e21f45762a824c/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
Comment 1 by bugdroid1@chromium.org
, Jan 9