New issue
Advanced search Search tips

Issue 920212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Remove SigninManager-related includes from external_component_loader.cc

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Look unused.
 
Owner: gyuyo...@igalia.com
I would like to take over this bug.
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6918e47e2ed076fba9f38ad60b6bc14d60659378

commit 6918e47e2ed076fba9f38ad60b6bc14d60659378
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Tue Jan 15 06:54:51 2019

s13n: Remove an unnecessary SigninManager related include in external_component_loader.cc

There are no uses of SigninManager in external_component_loader.cc.

Bug:  920212 
Change-Id: I4a4beb437f275c936153d912193245b4b5869ba8
Reviewed-on: https://chromium-review.googlesource.com/c/1410812
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622761}
[modify] https://crrev.com/6918e47e2ed076fba9f38ad60b6bc14d60659378/chrome/browser/extensions/external_component_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment