New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment
link

Issue 920208: Port enterprise_platform_keys_private_api_unittest.cc to use IdentityTestEnvironment rather than SigninManager

Reported by blundell@chromium.org, Jan 9 Project Member

Issue description

Should use IdentityTestEnvironment::MakePrimaryAccountAvailable() rather than SigninManager::SetAuthenticatedAccountInfo(). Please reach out if there are any complexities in the conversion.
 

Comment 1 by toniki...@chromium.org, Jan 9

Owner: toniki...@chromium.org
Status: Started (was: Available)

Comment 2 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4f719da5ca83c0bb44d771ac618df348ad02a4

commit ed4f719da5ca83c0bb44d771ac618df348ad02a4
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Sat Jan 12 04:34:40 2019

[s13n] Port enterprise_platform_keys_private_api_unittest.cc way from SigninManager

... in favor of identity testing utils.

SigninManager is going to be an implementation detail of IdentityManager. This CL
is a straightforward move between the two APIs.

BUG= 920208 

Change-Id: I4372b7c81fdd229ea6a7b34b67b2c32d03e00c92
Reviewed-on: https://chromium-review.googlesource.com/c/1405728
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622290}
[modify] https://crrev.com/ed4f719da5ca83c0bb44d771ac618df348ad02a4/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

Comment 3 by toniki...@chromium.org, Jan 12

Status: Fixed (was: Started)

Sign in to add a comment