New issue
Advanced search Search tips

Issue 920206 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Port sync_consent_screen.cc from SigninManager to IdentityManager

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Conversion looks straightforward.
 

Comment 1 by je_julie.kim@chromium.org, Jan 16 (6 days ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a017179b70d6098416d342889b5994cdd04331

commit b7a017179b70d6098416d342889b5994cdd04331
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Mon Jan 21 01:42:34 2019

[s13n] Convert SyncConsentScreen away from SigninManager

This CL makes SyncConsentScreen use IdentityManager instead
of SigninManager.

SigninManager is going to be an implementation detail of
IdentityManager.

Bug:  920206 
Change-Id: I0d429829ce337ca11f5485ca0298ccc2b9676237
Reviewed-on: https://chromium-review.googlesource.com/c/1420485
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624505}
[modify] https://crrev.com/b7a017179b70d6098416d342889b5994cdd04331/chrome/browser/chromeos/login/screens/sync_consent_screen.cc

Comment 3 by je_julie.kim@chromium.org, Jan 21 (2 days ago)

Status: Fixed (was: Started)

Sign in to add a comment