New issue
Advanced search Search tips

Issue 920203 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Remove SigninManager-related includes from chrome_browser_main_android.cc

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Includes look unused.
 
Owner: gyuyo...@igalia.com
I'd like to take over this bug.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27deff18dd90c3e95c7d3cefc6da6e004beeb92

commit d27deff18dd90c3e95c7d3cefc6da6e004beeb92
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Thu Jan 17 01:11:41 2019

s13n: Remove SigninManager-related includes from chrome_browser_main_android.cc

There are no uses of SigninManager|SigninManagerFactory in ChromeBrowserMainPartsAndroid.
So we don't need to keep the signin_manager.h and signing_manager_factory.h
includes in chrome_browser_main_android.cc.

Bug:  920203 
Change-Id: Ia43fe0fd75fe8ee2af9038bc4eaeb5419683d687
Reviewed-on: https://chromium-review.googlesource.com/c/1414210
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623489}
[modify] https://crrev.com/d27deff18dd90c3e95c7d3cefc6da6e004beeb92/chrome/browser/chrome_browser_main_android.cc

Comment 3 by gyuyo...@igalia.com, Jan 17 (5 days ago)

Status: Fixed (was: Available)

Sign in to add a comment