New issue
Advanced search Search tips

Issue 920201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Remove SigninManager-related includes from app_controller_mac.mm and its unittest

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Includes look unused.
 
Summary: Remove SigninManager-related includes from app_controller_mac.mm and its unittest (was: Remove SigninManager-related includes from app_controller_mac.mm)
Owner: gyuyo...@igalia.com
Let me take over this bug.

Comment 3 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fac5b1f2211b8323d145dc8cfbddc9594dc9fbaf

commit fac5b1f2211b8323d145dc8cfbddc9594dc9fbaf
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Thu Jan 17 01:12:48 2019

s13n: Remove SigninManager-related includes from app_controller_mac.mm and its unittest

Clean up sign-in-related code in app_controller_mac.mm and app_controller_mac_unittest.mm
because there are no uses of SigninManager.

Bug:  920201 
Change-Id: I0466c2ccea572af4f60cc1fbbd7b5584bd2b586c
Reviewed-on: https://chromium-review.googlesource.com/c/1414211
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623491}
[modify] https://crrev.com/fac5b1f2211b8323d145dc8cfbddc9594dc9fbaf/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/fac5b1f2211b8323d145dc8cfbddc9594dc9fbaf/chrome/browser/app_controller_mac_unittest.mm

Sign in to add a comment