Issue metadata
Sign in to add a comment
|
V8 testfilter is incorrectly passed to triggered builders |
||||||||||||||||||||||
Issue descriptionSee the pair: https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_android_arm64_n5x_rel_ng/b8924800335021940000 https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_android_arm64_n5x_rel_ng_triggered/b8924799998810944016 The first still has a correct property. The second now has strings interpreted as lists. This has worked until recently. Maybe some change based on how properties are passed with buildbucket?
,
Jan 10
Issue was with how this builder was scheduled: git cl try -B luci.v8.try -b v8_android_arm64_n5x_rel_ng -p "testfilter=['cctest/test-cpu-profiler/Inlining2']" Here the value for testfilter is not JSON-decodeable due to singular quotes and thus passed as a string. Instead one need to schedule try builds like this: git cl try -B luci.v8.try -b v8_android_arm64_n5x_rel_ng -p 'testfilter=["cctest/test-cpu-profiler/Inlining2"]'
,
Jan 10
Yep, this bit me again. Works now indeed: https://chromium-review.googlesource.com/c/v8/v8/+/1403116 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by no...@chromium.org
, Jan 9