New issue
Advanced search Search tips

Issue 920192 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Remove SigninManager-related includes from web_view_password_manager_client.mm

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

These includes look like they're unused.
 

Comment 1 by je_julie.kim@chromium.org, Jan 16 (6 days ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33561dd9b74dc973b2a94bf1cc9d93f3402c3f28

commit 33561dd9b74dc973b2a94bf1cc9d93f3402c3f28
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Jan 18 07:53:19 2019

[s13n] Remove unused header from web_view_password_manager_client.mm

This CL removes unused header, web_view_signin_manager_factory.h, from
web_view_password_manager_client.mm

Bug:  920192 
Change-Id: Ibb3ba9670bb17017b4d104af75032d02aa97c0b1
Reviewed-on: https://chromium-review.googlesource.com/c/1420484
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624031}
[modify] https://crrev.com/33561dd9b74dc973b2a94bf1cc9d93f3402c3f28/ios/web_view/internal/passwords/web_view_password_manager_client.mm

Comment 3 by je_julie.kim@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment