New issue
Advanced search Search tips

Issue 920181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Execute WebAssembly optimizing compilation on low priority background threads.

Project Member Reported by ahaas@chromium.org, Jan 9

Issue description

WebAssembly optimizing compilation with TurboFan can run for quite
some time. We see examples, e.g.  https://crbug.com/914757 , where
more important tasks get blocked by TurboFan compilation. We want to
run TurboFan with lower priority so that it does not block other tasks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/75a780920a5810bfccb2ce54d0aa68c92d8fa7b6

commit 75a780920a5810bfccb2ce54d0aa68c92d8fa7b6
Author: Andreas Haas <ahaas@chromium.org>
Date: Mon Jan 14 15:45:01 2019

[v8][api] Add API function CallLowPriorityTaskOnWorkerThread

When we run TurboFan compilation for WebAssembly on worker threads with
default priority, we see in bug reports ( https://crbug.com/914757 ) and
in experiments that TurboFan compilation can block other, higher
priority tasks. Therefore we want to post TurboFan compilation tasks
with lower priority.

A quick prototype showed that if we run all WebAssembly compilation with
low priority, the problem described in  https://crbug.com/914757  is
fixed.

R=adamk@chromium.org
CC=rmcilroy@chromium.org

Bug:  chromium:920181 
Change-Id: I85e2c0c6a96ff9ef165a23ef8eb531944b20f2b0
Reviewed-on: https://chromium-review.googlesource.com/c/1402790
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58792}
[modify] https://crrev.com/75a780920a5810bfccb2ce54d0aa68c92d8fa7b6/include/v8-platform.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4023ccb2d739351889cc3e929d13e577ab7ced

commit 6d4023ccb2d739351889cc3e929d13e577ab7ced
Author: Andreas Haas <ahaas@chromium.org>
Date: Fri Jan 18 13:16:00 2019

[v8][gin] Implement CallLowPriorityTaskOnWorkerThread

In https://crrev.com/c/1402790, we introduced a new API function in the
V8 platform API to allow posting of low priority tasks. An example of
such a low priority task is TurboFan compilation for WebAssembly, which
should not delay user-visible tasks like WebAssembly baseline
compilation. This CL is the implementation of that API function in the
gin platform.

R=rmcilroy@chromium.org

Bug:  chromium:920181 
Change-Id: I798a594a898a9251e0b2c9ebc277864540b9a3e3
Reviewed-on: https://chromium-review.googlesource.com/c/1412461
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624094}
[modify] https://crrev.com/6d4023ccb2d739351889cc3e929d13e577ab7ced/gin/public/v8_platform.h
[modify] https://crrev.com/6d4023ccb2d739351889cc3e929d13e577ab7ced/gin/v8_platform.cc

Comment 3 by ahaas@chromium.org, Yesterday (41 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment