Issue metadata
Sign in to add a comment
|
Invalidations are broken for Chrome on Android |
||||||||||||||||||||||
Issue descriptionChrome Version: M72 OS: Android What steps will reproduce the problem? (1) Enable Sync on Chrome for Android (2) Create bookmark on another device (3) Open chrome://invalidations on the device from step (1) What is the expected result? Invalidation for bookmark, created on the step (2) arrives to the device. What happens instead? No invalidations are recieved by device
,
Jan 9
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6025200fe86e5800909c520894cb905115871e3c commit 6025200fe86e5800909c520894cb905115871e3c Author: Tanja Gornak <melandory@chromium.org> Date: Wed Jan 09 13:56:44 2019 [Tango->FCM] Tango invalidation service should be created when FCM feature disabled. Bug: 920175 TBR=nyquist@chromium.org Change-Id: Idc61fa086b3325b803141df0c0c798c483e7105b Reviewed-on: https://chromium-review.googlesource.com/c/1402875 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#621132} [modify] https://crrev.com/6025200fe86e5800909c520894cb905115871e3c/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeInvalidationClientService.java
,
Jan 9
,
Jan 9
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 9
Pls bug with canary result tomorrow and comment on merge safety. Thank you.
,
Jan 10
The NextAction date has arrived: 2019-01-10
,
Jan 10
Confirming that it works in canary. Safe to merge
,
Jan 10
Last night canary which includes this fix failed 73.0.3667.0, pls see bug 920520. May I please know which version you verify the fix?
,
Jan 10
Hm, chrome://version is even 3666 Let me check, whats going on.
,
Jan 10
Ok, I see now what has happened. For the Chrome instance where I've checked the issue, I was the part on the FCMInvalidations experiment, which doesn't have the issue at all. That's explain why it worked. Sorry, I'll explicitly disable the feature next time, when I'm checking.
,
Jan 10
Ok, I see now what has happened. For the Chrome instance where I've checked the issue, I was the part on the FCMInvalidations experiment, which doesn't have the issue at all. That's explain why it worked. Sorry, I'll explicitly disable the feature next time, when I'm checking.
,
Jan 10
No worries, pls update bug with canary result tomorrow. Thank you.
,
Jan 11
It works. Another question. What is the process to request the re-spin for Beta?
,
Jan 11
The NextAction date has arrived: 2019-01-11
,
Jan 11
Approving merge to M72 branch 3626 based on comment #14. Please merge ASAP so we can pick it up for next Beta release on 01/16. Pls mark bug as fixed after the merge. Thank you.
,
Jan 11
Pls merge your change to M72 branch 3626 latest by 1:00 PM PT, Monday (11/14) so we can pick it up for next week beta release. Thank you.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f807c0b9572f5c0bc8ae6eadff5dd966821d6a3f Commit: f807c0b9572f5c0bc8ae6eadff5dd966821d6a3f Author: melandory@chromium.org Commiter: melandory@chromium.org Date: 2019-01-14 08:45:40 +0000 UTC [Tango->FCM] Tango invalidation service should be created when FCM feature disabled. Bug: 920175 TBR=melandory@chromium.org, nyquist@chromium.org (cherry picked from commit 6025200fe86e5800909c520894cb905115871e3c) Change-Id: Idc61fa086b3325b803141df0c0c798c483e7105b Reviewed-on: https://chromium-review.googlesource.com/c/1402875 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621132} Reviewed-on: https://chromium-review.googlesource.com/c/1408450 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#659} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f807c0b9572f5c0bc8ae6eadff5dd966821d6a3f commit f807c0b9572f5c0bc8ae6eadff5dd966821d6a3f Author: Tanja Gornak <melandory@chromium.org> Date: Mon Jan 14 08:45:40 2019 [Tango->FCM] Tango invalidation service should be created when FCM feature disabled. Bug: 920175 TBR=melandory@chromium.org, nyquist@chromium.org (cherry picked from commit 6025200fe86e5800909c520894cb905115871e3c) Change-Id: Idc61fa086b3325b803141df0c0c798c483e7105b Reviewed-on: https://chromium-review.googlesource.com/c/1402875 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621132} Reviewed-on: https://chromium-review.googlesource.com/c/1408450 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#659} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f807c0b9572f5c0bc8ae6eadff5dd966821d6a3f/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeInvalidationClientService.java
,
Jan 14
Can this be marked as fixed if nothing else is pending?
,
Jan 15
Marking as fixed, nothing else is pending. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mastiz@google.com
, Jan 9Labels: -Type-Bug Sync-Triaged RegressedIn-72 M-72 Type-Bug-Regression
Status: Started (was: Untriaged)