New issue
Advanced search Search tips

Issue 920162 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jan 17
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Extension doesn't hide in wrench menu after dragging from toolbar

Project Member Reported by khush...@virtusa.com, Jan 9 
Chrome version: 73.0.3666.0 (Official Build) (64-bit) Revision f4b6c3052a8b2a249b9c6c0ed3e94d9187b1dd6a-refs/branch-heads/3666@{#1} (32/64 bit)

OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3) and Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome and install any extension from Chrome Web Store (extension will get installed in toolbar).
(2) Now drag the extension from toolbar and put it in to the wrench menu.
(3) Observe.

Actual Result: Extension doesn't hide at some locations in wrench menu after dragging from toolbar.

Expected Result: Extension should hide in wrench menu after dragging from toolbar.

This is a regression issue broken in ‘M-73’, below is the Manual Regression range:
Good build: 73.0.3661.0 (Revision: 619955)
Bad build:  73.0.3662.0 (Revision: 620151)

Using Per-revision script, providing the bisect result below:

You are probably looking for a change made after 619998 (known good), but no later than 619999 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/df014e7cdf7709de15c09bc7ad96f62e914ca863..82848abbf09b0cf470a2f06a617fe681d87f7f8a

Suspect: https://chromium.googlesource.com/chromium/src/+/82848abbf09b0cf470a2f06a617fe681d87f7f8a

@pbos: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-73 Dev (build #73.0.3664.3).

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mp4
683 KB View Download
Expected Video.mp4
678 KB View Download

Comment 1 by nyerramilli@chromium.org, Jan 9

Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 2 by rbasuvula@chromium.org, Jan 14 

Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19a0c1ed924f2a632c6255fe311d6819568c031f

commit 19a0c1ed924f2a632c6255fe311d6819568c031f
Author: Peter Boström <pbos@chromium.org>
Date: Thu Jan 17 22:38:23 2019

Use unclamped extension count for in-menu width

This prevents clamping the BrowserActionsContainer width to the number
of installed extensions, which prevented extensions to be dropped in the
entire menu-item area.

Bug:  chromium:920162 
Change-Id: Ic4f009746b89c88f5cea6862eca0e13c219e5c15
Reviewed-on: https://chromium-review.googlesource.com/c/1409920
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623879}
[modify] https://crrev.com/19a0c1ed924f2a632c6255fe311d6819568c031f/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/19a0c1ed924f2a632c6255fe311d6819568c031f/chrome/browser/ui/toolbar/toolbar_actions_bar.h

Comment 4 by pbos@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)
This should be fixed now, please verify. Sorry about the slow update rbasuvula@.
►

Sign in to add a comment