CL https://chromium-review.googlesource.com/c/chromium/src/+/1403157

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c90b24cdcb8373bf6a0fe3f404e74c818617b34

commit 0c90b24cdcb8373bf6a0fe3f404e74c818617b34
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Jan 09 15:32:49 2019

Remove {SigninManager,PO2TS,AccountTrackerService}::RegisterProfilePref calls from profile_sync_test_util.cc

This is done by identity::IdentityTestEnvironment when it is created.

BUG= 920155 

Change-Id: I29174997fed10dc6a237bc037462ed2854a1d2f0
Reviewed-on: https://chromium-review.googlesource.com/c/1403154
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#621150}
[modify] https://crrev.com/0c90b24cdcb8373bf6a0fe3f404e74c818617b34/components/browser_sync/profile_sync_test_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14092d58c0d5fcb8474b12e69d969beb51976c89

commit 14092d58c0d5fcb8474b12e69d969beb51976c89
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Jan 10 12:11:44 2019

Replace signin_investigator_unittest's usage of SigninManagerBase:::RegisterProfilePrefs() with an IdentityTestEnvironment ivar

CL also allows removal of the signin_manager_base.h include.

BUG= 920155 

Change-Id: I726878eb49545ea8b97e5565bab487711309384b
Reviewed-on: https://chromium-review.googlesource.com/c/1403157
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#621550}
[modify] https://crrev.com/14092d58c0d5fcb8474b12e69d969beb51976c89/components/signin/core/browser/signin_investigator_unittest.cc

commnent #4 is the actual fix here.

comment #3 is a similar driven-by fix, that I use this bug to find.