New issue
Advanced search Search tips

Issue 920153 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Port google_password_manager_navigation_throttle_browsertest to use IdentityManager rather than SigninManager

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Should be straightforward.
 
Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b7683566ae5b122b6acd88d8b0e820fcd7d410

commit 20b7683566ae5b122b6acd88d8b0e820fcd7d410
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Wed Jan 16 14:09:14 2019

[s13n] Convert GooglePasswordManagerNavigationThrottleTest to IdentityManager

This CL only migrates GooglePasswordManagerNavigationThrottleTest
production code away from SigninManager.

Bug:  920153 
Change-Id: Ibd55b58baf4ec7384989fa4de23dbc636bd17996
Reviewed-on: https://chromium-review.googlesource.com/c/1414532
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623223}
[modify] https://crrev.com/20b7683566ae5b122b6acd88d8b0e820fcd7d410/chrome/browser/ui/passwords/google_password_manager_navigation_throttle_browsertest.cc

Comment 3 by je_julie.kim@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment