New issue
Advanced search Search tips

Issue 920152 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Change signin_profile_attributes_updater to use IdentityManager rather than SigninManager

Project Member Reported by blundell@chromium.org, Jan 9

Issue description

Should be straightforward.
 
Owner: hferre...@igalia.com
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1e24223c2a9544a849d75ef8f1ec920ca0b1a9

commit 7d1e24223c2a9544a849d75ef8f1ec920ca0b1a9
Author: Henrique Ferreiro <hferreiro@igalia.com>
Date: Thu Jan 10 15:26:46 2019

Change signin_profile_attributes_updater to use IdentityManager

Rename callbacks GoogleSigninSucceeded and GoogleSignedOut to
OnPrimaryAccountSet and OnPrimaryAccountCleared.

Bug:  920152 
Change-Id: I9f4e8473bf7b59043b7ff128d8932f02810fcf29
Reviewed-on: https://chromium-review.googlesource.com/c/1402807
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621584}
[modify] https://crrev.com/7d1e24223c2a9544a849d75ef8f1ec920ca0b1a9/chrome/browser/signin/signin_profile_attributes_updater.cc
[modify] https://crrev.com/7d1e24223c2a9544a849d75ef8f1ec920ca0b1a9/chrome/browser/signin/signin_profile_attributes_updater.h
[modify] https://crrev.com/7d1e24223c2a9544a849d75ef8f1ec920ca0b1a9/chrome/browser/signin/signin_profile_attributes_updater_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment