Mac PWAs: Long title text displayed with little side spacing |
||||
Issue descriptionProposal: Add 10% of window width as side spacings for title text
,
Jan 9
sdy@ I think someone non-Mac is working on the toolbar, can you route?
,
Jan 9
That would be me.
,
Jan 9
Screenshots for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1404220
,
Jan 10
LGTM. Thanks much alancutter@!
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ebcc27455d7bc201a44b5cc65c3f8d7c97374b commit a0ebcc27455d7bc201a44b5cc65c3f8d7c97374b Author: Alan Cutter <alancutter@chromium.org> Date: Fri Jan 11 04:01:34 2019 Add 10% width horizontal padding to PWA title text on Mac This CL adds padding to either side of the PWA window title text equal to 10% of the window's total width. Wide: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=374373&signed_aid=Mb0qmKQfCNl-MOXiVruWoA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=374374&signed_aid=TCm4CM_GEvKgFa7H-UBKDQ==&inline=1 Narrow: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=374371&signed_aid=d2hcAu66BJ8VrOwhpOWkxQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=374372&signed_aid=IxLJcD_CrOat9fWPKdihCQ==&inline=1 Bug: 920150 Change-Id: I94114adb0eb450bac29c85b97911697598683ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1404220 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#621898} [modify] https://crrev.com/a0ebcc27455d7bc201a44b5cc65c3f8d7c97374b/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Jan 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hwi@chromium.org
, Jan 9