New issue
Advanced search Search tips

Issue 920139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Implement RWHVA::GetCompositionTextRange.

Project Member Reported by yhanada@chromium.org, Jan 9

Issue description

It's left as unimplemented, but needed by Android IME support on Chrome OS. Let's implement it.

 
Components: Platform>Apps>ARC
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0412a65c76169c008d97fd41e008b7f24161a8

commit da0412a65c76169c008d97fd41e008b7f24161a8
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Jan 10 00:48:32 2019

Implement RWHVA::GetCompositionTextRange().

Bug:  920139 
Test: content_unittests
Change-Id: I687e6a90b2bae810bb714cd58178e9936f4a9e17
Reviewed-on: https://chromium-review.googlesource.com/c/1401864
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621396}
[modify] https://crrev.com/da0412a65c76169c008d97fd41e008b7f24161a8/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/da0412a65c76169c008d97fd41e008b7f24161a8/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0029d939117dcf2184496c555c014b065fadbcd6

commit 0029d939117dcf2184496c555c014b065fadbcd6
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Jan 10 05:41:09 2019

Add composition_text_range field to TextInputState struct.

I can't use [MinVersion] prefix for struct, so added two fields to the
struct instead.

Bug:  920139 
Test: Ran on DUT.
Change-Id: I05f793a5e795d7bbc5cec70ca0e5a1372893bb78
Reviewed-on: https://chromium-review.googlesource.com/c/1402385
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621472}
[modify] https://crrev.com/0029d939117dcf2184496c555c014b065fadbcd6/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc
[modify] https://crrev.com/0029d939117dcf2184496c555c014b065fadbcd6/components/arc/common/input_method_manager.mojom

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0155e73a4c0799ab456d2f515cea62b22fe00bf

commit f0155e73a4c0799ab456d2f515cea62b22fe00bf
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Jan 18 04:08:52 2019

Use "Range?" instead of two integers for composition_text_range.

A nullable field should be cleaner than two integer values and
a null value.

Bug:  920139 
Change-Id: Iec1ffad0394e2547557a005ac9fa824ad99895e3
Reviewed-on: https://chromium-review.googlesource.com/c/1411961
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624001}
[modify] https://crrev.com/f0155e73a4c0799ab456d2f515cea62b22fe00bf/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc
[modify] https://crrev.com/f0155e73a4c0799ab456d2f515cea62b22fe00bf/components/arc/common/input_method_manager.mojom

Sign in to add a comment