New issue
Advanced search Search tips

Issue 920123 link

Starred by 1 user
Status: Fixed
Owner:
lethalantidote@chromium.org
Closed: Jan 17
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted blue focus ring is seen for labels when clicked.

Project Member Reported by aim...@virtusa.com, Jan 9 
Chrome Version: 73.0.3665.0 (Official Build) 629bcca8b1de535bfd36b12e4a3cb7c1b07c9e48-refs/branch-heads/3665@{#1} (32/64 Bit).

OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3), Linux(14.04 LTS).

Test URL: https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html

What steps will reproduce the problem?
1. Launch chrome and navigate to above test URL.
2. Click on 3 dot menu icon in video and click on the label of any option in the list.
3. Observe.

Actual Result: Unwanted blue focus ring is seen for labels on overflow menu when clicked.
Expected Result: Unwanted blue focus ring should not be seen when labels on overflow menu is clicked.

This is a regression issue broken in M-73 and will soon update other info:
Good Build : 73.0.3661.0 (Revision : 619955)
Bad Build : 73.0.3662.0 (Revision : 620151)

Note:
1. Issue is also seen on Dev #73.0.3664.3 builds.

Kindly refer the screen cast for reference

Thank You!
Actual Result.mp4
413 KB View Download
Expected Result.mp4
399 KB View Download

Comment 1 by aim...@virtusa.com, Jan 9

Labels: hasbisect-per-revision
Owner: lethalantidote@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

You are probably looking for a change made after 620107 (known good), but no later than 620108 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/77ed09dacadb3523047787e6d0eed0cc14b16ef3..6c13ccee25976d63d861d4e0385f846dba9affd9

Suspect: https://chromium.googlesource.com/chromium/src/+/6c13ccee25976d63d861d4e0385f846dba9affd9

@CJ DiMeglio : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue can also be reproduced on following test URL's --
- https://www.quirksmode.org/html5/tests/video.html
- http://googlechrome.github.io/samples/picture-in-picture
2. Issue is also seen on latest Canary build #73.0.3666.0

Thank you..!

Comment 2 by lethalantidote@chromium.org, Jan 16

Status: WontFix (was: Assigned)
I believe this is an intended change, adding mlamouri to double check.

Comment 3 by lethalantidote@chromium.org, Jan 16

Cc: mlamouri@chromium.org
+mlamouri

Comment 4 by mlamouri@chromium.org, Jan 16 (6 days ago)

Labels: -Pri-1 Pri-2
Status: Assigned (was: WontFix)
I can't repro on Windows Canary but it seems like something we could fix. There is no need to show the focus ring for the options as, as seen in the video, the focus ring is only visible for a very short amount of time and then hides.

Re-opening to make sure we answer the open questions here. Definitely not a P1 though.

Comment 5 by lethalantidote@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Assigned)
This was caused by setting overflow_menu_container_->setTabIndex(-1);, which since has been removed. It should no longer be repro-able.

https://chromium-review.googlesource.com/c/chromium/src/+/1407964
►

Sign in to add a comment