New issue
Advanced search Search tips

Issue 920093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Implement gen_grpc parameter in proto_library.gni

Project Member Reported by yamaguchi@chromium.org, Jan 9

Issue description

as of deeb14aeb5c

#   gen_grpc (optional)
#       If true, generates C++ GRPC.

The instantiation of the template fails when gen_grpc is set to true or 1.
> ERROR at //common-mk/proto_library.gni:34:3: Action has no outputs.
>   action_foreach(action_name) {
>   ^----------------------------

Additionally it needs to acquire path of the grpc_cpp_plugin binary to "grpc_cpp_plugin" variable inside the template.
 

Comment 1 by yamaguchi@chromium.org, Yesterday (28 hours ago)

Status: Fixed (was: Started)
This has been resolved by 
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1401963

Sign in to add a comment