New issue
Advanced search Search tips

Issue 920073 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

single_process_mash_browser_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 9

Issue description

Components: Blink>Editing>IME
Labels: OS-Chrome
Owner: mukai@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ec9ad1528347e6b2d7146966437bb89c5e9169

commit 59ec9ad1528347e6b2d7146966437bb89c5e9169
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Jan 09 22:42:01 2019

Reland "wait properly for the keyboard bounds change"

Instead of RunUntilIdle, it should wait for OnKeyboardOccludedBoundsChange.
This CL also allows to resize the window which remotely hosts the VK
web-contents based on window.resizeTo().

This is a reland of crrev.com/c/1394595 with an addition of waiting
the processing of SetBounds in MockEnableIMEInDifferentExtension().

TBR=stevenjb@chromium.org, xiyuan@chromium.org

Bug: 916177,  920073 
Test: browser_tests
Change-Id: Ib353f5193ab4f7bb907a6c02ece6429b42408919
Reviewed-on: https://chromium-review.googlesource.com/c/1403923
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621343}
[modify] https://crrev.com/59ec9ad1528347e6b2d7146966437bb89c5e9169/ash/keyboard/ash_keyboard_ui.cc
[modify] https://crrev.com/59ec9ad1528347e6b2d7146966437bb89c5e9169/chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc

Status: Fixed (was: Assigned)
seems reland is okay.

Sign in to add a comment