New issue
Advanced search Search tips

Issue 920062 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocking:
issue 877898



Sign in to add a comment

WebApps: Improve testing utilities, mocks and infrastructure.

Project Member Reported by loyso@chromium.org, Jan 9

Issue description

Provide better test support for unit tests and browser tests in Web Applications and Bookmark Applications area.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0392757ad46b0315e11c30db3426a9c7a105c87

commit d0392757ad46b0315e11c30db3426a9c7a105c87
Author: Alexey Baskakov <loyso@chromium.org>
Date: Thu Jan 10 08:38:28 2019

WebApp: Cleanup WebAppProvider browser tests infrastructure.

Introduce TestWebAppProvider.
This will allow us to simulate real WebApps environment in
browser end-to-end tests.

Split up WebAppProvider Initialization into two passes:
- Create a graph of polymorphic subsystems.
- Initialize subsystems: post scheduled tasks, start IO etc.
It allows tests to substitute selected subsystems with mock
instances OR skip/replace a whole CreateSubsystems or Init pass.

- Remove recreation of WebAppAudioFocusIdMap
- Remove fake WebAppProvider::Get()->Reset() call in
SystemWebAppManager end-end test.
- Use TestWebAppProvider with PendingAppManager in
SystemWebAppManager tests.

TBR=msw@chromium.org

Bug: 920062
Change-Id: Id4d49da133da0fdb606b5dba3cc1f926df416614
Reviewed-on: https://chromium-review.googlesource.com/c/1399772
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621503}
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/BUILD.gn
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.h
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc
[add] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/test_web_app_provider.cc
[add] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/bookmark_apps/test_web_app_provider.h
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/components/web_app_tab_helper_base.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/system_web_app_manager.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/system_web_app_manager.h
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/test/test_system_web_app_manager.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/test/test_system_web_app_manager.h
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/web_app_provider.cc
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/web_app_provider.h
[modify] https://crrev.com/d0392757ad46b0315e11c30db3426a9c7a105c87/chrome/browser/web_applications/web_app_provider_factory.cc

Sign in to add a comment