New issue
Advanced search Search tips

Issue 920060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 899586



Sign in to add a comment

Migrate video_VDASanity to Tast

Project Member Reported by deanliao@chromium.org, Jan 9

Issue description

video_VDASanity [1] is a video test which runs a binary unittest[2] on DUT.
We migrate this to a new test framework, Tast.

[1] https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/site_tests/video_VDASanity/
[2] https://cs.chromium.org/chromium/src/media/gpu/video_decode_accelerator_unittest.cc
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/b538f0012f0586e75d072f34473533886d425a42

commit b538f0012f0586e75d072f34473533886d425a42
Author: Dean Liao <deanliao@chromium.org>
Date: Tue Jan 15 10:54:52 2019

video: Migrate video_VDASanity autotest to Tast.

Modify RunAccelVideoTest() to accept TestConfig argument instead of
TestVideoData and VDABufferMode arguments. TestConfig contains
TestVideoData, VDABufferMode, test video path, optional thumbnail path
and optional gtest filter. With TestConfig, we can compose flags for
video_decode_accelerator_unittest.

Rename RunAccelVideoTest() as private runAccelVideoTest(). Tests shall
use RunAllAccelVideoTest() for general decode accelerated video test;
use RunAccelVideoSanityTest() for running
VideoDecodeAcceleratorTest.NoCrash test.

With above change, we can migrate video_VDASanity autotest to Tast test
named video.DecodeAccelSanityVP9{1|2|3} and
video.DecodeAccelSanityVP90CtsShowExistingFrame.

For test video used for video.DecodeAccelSanityVP9*, they are copied
from
gs://chromiumos-test-assets-public/video_VDASanity/

Steps to generate vda_sanity-bear_profile{1|2|3}.vp9:
(refer https://chromium-review.googlesource.com/461760)

1. bear-1280x720.mp4 is from in chrome_src/media/test/data.

2. Generate bear_422.yuv and bear_420.yuv
    avconv -i bear-1280x720.mp4 -s 320x180 -c:v rawvideo -pix_fmt yuv422p \
      -frames 30 bear_422.yuv
    avconv -i bear-1280x720.mp4 -s 320x180 -c:v rawvideo -pix_fmt yuv420p \
      -frames 30 bear_420.yuv

3. Encode
    COMMON="
     --codec=vp9 -w 320 -h 180 --ivf --kf-min-dist=0 --kf-max-dist=150
     --lag-in-frames=24 --drop-frame=0 --target-bitrate=140 --cq-level=23
     --min-q=4 --max-q=56 --static-thresh=1000 --arnr-maxframes=7
     --arnr-strength=5 --arnr-type=3 --cpu-used=1 --good --tile-columns=1
     --passes=2 --threads=1 --end-usage=cq --auto-alt-ref=1 --bias-pct=50
     --minsection-pct=0 --maxsection-pct=2000 --undershoot-pct=100"

    ./vpxenc bear_422.yuv -o vda_sanity-bear_profile1.vp9 --profile=1 --i422 $COMMON
    ./vpxenc bear_420.yuv -o vda_sanity-bear_profile2.vp9 --profile=2 --i420 \
      --bit-depth=10 $COMMON
    ./vpxenc bear_422.yuv -o vda_sanity-bear_profile3.vp9 --profile=3 --i422 \
      --bit-depth=10 $COMMON

For vda_sanity-vp90_2_17_show_existing_frame.vp9, it is from Android CTS:
https://android.googlesource.com/platform/cts/+/master/tests/tests/media/res/raw/vp90_2_17_show_existing_frame.vp9
which causes elm kernel crash.

BUG= chromium:920060 
TEST=tast run bob video.VDASanity

Change-Id: I964fb03235168b3327a23bba88276d71743ce7f9
Reviewed-on: https://chromium-review.googlesource.com/1401907
Commit-Ready: Shuo-Peng Liao <deanliao@google.com>
Tested-by: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>

[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode/test_cases.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp8_import.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/data/vda_sanity-vp90_2_17_show_existing_frame.vp9.external
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_sanity_vp93.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_h264.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode/accel_video.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_sanity_vp92.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/data/vda_sanity-bear_profile3.vp9.external
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp9.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp92_import.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp9_import.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/data/vda_sanity-bear_profile2.vp9.external
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/data/vda_sanity-bear_profile1.vp9.external
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp8.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_sanity_vp90_cts_show_existing_frame.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_h264_import.go
[add] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_sanity_vp91.go
[modify] https://crrev.com/b538f0012f0586e75d072f34473533886d425a42/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp92.go

Comment 2 by deanliao@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment