New issue
Advanced search Search tips

Issue 920039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

virtual/layout_ng_experimental/css3/flexbox/flex-align-baseline.html and 4 other(s) in not_site_per_process_webkit_layout_tests failing on chromium.linux/Linux Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 9

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of hajimehoshi@chromium.org

virtual/layout_ng_experimental/css3/flexbox/flex-align-baseline.html and 4 other(s) in not_site_per_process_webkit_layout_tests failing on chromium.linux/Linux Tests

Builders failed on: 
- Linux Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests


 
Owner: dgro...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d8923f2015fbf90c100abda3a9989d4096119d

commit 99d8923f2015fbf90c100abda3a9989d4096119d
Author: David Grogan <dgrogan@chromium.org>
Date: Wed Jan 09 02:46:57 2019

Reland [LayoutNG] Calculate flex container intrinsic sizes

The 7 tests marked Crash crash locally for me and crashed on the trybots
but don't on one of the continuous builders[1], possibly that runs
without DCHECK enabled. 5 of the tests failed and 2 passed. The failures
surfaced as regressions, which got this patch reverted. So just go back
to Skip.

[1] https://test-results.appspot.com/data/layout_results/Linux_Tests/74761/webkit_layout_tests/layout-test-results/results.html

TBR=mstensho@chromium.org

Bug: 845235, 920039 
Change-Id: I3970b3fd77633240a21198358b3f1913022977f3
Reviewed-on: https://chromium-review.googlesource.com/c/1401673
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621015}
[modify] https://crrev.com/99d8923f2015fbf90c100abda3a9989d4096119d/third_party/blink/renderer/core/layout/ng/geometry/ng_box_strut.h
[modify] https://crrev.com/99d8923f2015fbf90c100abda3a9989d4096119d/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
[modify] https://crrev.com/99d8923f2015fbf90c100abda3a9989d4096119d/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h
[modify] https://crrev.com/99d8923f2015fbf90c100abda3a9989d4096119d/third_party/blink/web_tests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment