Enable the network service on ChromeOS |
||
Issue descriptionThis is a tracking bug for enabling the Network Service on ChromeOS. The current plan is the same as Mash's as of January 8th: 1. Enable the network service in C++ for a few days so hardware tests can run, and for developers to file bug reports 2. Disable the network service after a couple days, or if a bug is found 3. Repeat 1-2 until no bugs are found 4. Launch with finch as you would any other feature
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7112246b3dbeebf99659871f89c8e27fbeb7ec4b commit 7112246b3dbeebf99659871f89c8e27fbeb7ec4b Author: Robbie McElrath <rmcelrath@chromium.org> Date: Mon Jan 14 21:23:20 2019 Enable the Network Service by default on ChromeOS. This enables the network service by default, and disables it at the beginning of unit tests, since they don't currently work with the network service enabled. This will be reverted after a few days, or earlier if it causes problems. We're only enabling it by default to make sure all test suites (in particular the hardware autotests) have a chance to run with it enabled, and to get bug reports from developers. Bug: 920038 Change-Id: Iff9a2ab08b82d4446e327b685be1bca8cf61917b Reviewed-on: https://chromium-review.googlesource.com/c/1399297 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#622606} [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/components/test/DEPS [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/components/test/components_test_suite.cc [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/content/public/test/content_test_suite_base.cc [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/content/public/test/content_test_suite_base.h [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/services/network/public/cpp/features.cc [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/testing/buildbot/chromium.memory.json [modify] https://crrev.com/7112246b3dbeebf99659871f89c8e27fbeb7ec4b/testing/buildbot/test_suites.pyl
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba commit 4dfaf6c9c14919c7409d95058dd5dbb13f9457ba Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Jan 15 05:21:13 2019 Revert "Enable the Network Service by default on ChromeOS." This reverts commit 7112246b3dbeebf99659871f89c8e27fbeb7ec4b. Reason for revert: Possibly caused crbug.com/921814 Original change's description: > Enable the Network Service by default on ChromeOS. > > This enables the network service by default, and disables it at the > beginning of unit tests, since they don't currently work with the > network service enabled. > > This will be reverted after a few days, or earlier if it causes > problems. We're only enabling it by default to make sure all test > suites (in particular the hardware autotests) have a chance to run > with it enabled, and to get bug reports from developers. > > Bug: 920038 > Change-Id: Iff9a2ab08b82d4446e327b685be1bca8cf61917b > Reviewed-on: https://chromium-review.googlesource.com/c/1399297 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622606} TBR=jam@chromium.org,rmcelrath@chromium.org Change-Id: I0403f965966a8d658c94cfbc8856424179b0b0d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920038 Reviewed-on: https://chromium-review.googlesource.com/c/1411072 Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#622740} [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/components/test/DEPS [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/components/test/components_test_suite.cc [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/content/public/test/content_test_suite_base.cc [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/content/public/test/content_test_suite_base.h [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/services/network/public/cpp/features.cc [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/testing/buildbot/chromium.memory.json [modify] https://crrev.com/4dfaf6c9c14919c7409d95058dd5dbb13f9457ba/testing/buildbot/test_suites.pyl
,
Jan 15
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 10