New issue
Advanced search Search tips

Issue 920023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[SingleProcessMash] can resize browser too small

Project Member Reported by sky@chromium.org, Jan 8

Issue description

It would appear SPM doesn't honor the minimum size. This means you can resize browsers smaller than you should be able to.
 
Cc: est...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9

commit 8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9
Author: Scott Violet <sky@chromium.org>
Date: Wed Jan 09 16:15:34 2019

ash: makes WmNativeWidgetAura override GetMinimumSize()

And calls to aura::client::kMinimumSize. This way, if a client removes the
standard frame (the client is drawing the non-client area) the min size is
honored.

BUG= 920023 
TEST=covered by test

Change-Id: Ib653cf6b2d64c4d53199c5137faa2747171cf902
Reviewed-on: https://chromium-review.googlesource.com/c/1401618
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621165}
[modify] https://crrev.com/8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9/ash/test/ash_test_base.cc
[modify] https://crrev.com/8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9/ash/test/ash_test_base.h
[modify] https://crrev.com/8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/8d2e4ecfaa1f62cf8e086e2cc68c635ec8bffcd9/ash/wm/non_client_frame_controller_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment