Findit identified the culprit r620743 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMmQ1YjRiNmJhYzUyY2E2YTViZGRhZTU0MTIzNjEwZDI5NjdiMjA2MAw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r620743&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMmQ1YjRiNmJhYzUyY2E2YTViZGRhZTU0MTIzNjEwZDI5NjdiMjA2MAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Discussed this in the team and it seems we should not be changing the feature list after the threads are created. Though there are lots of tests in the code base doing that. Creating a CL to fix this.
Cl out for review: https://chromium-review.googlesource.com/c/chromium/src/+/1403178 Verified the root cause as per the comment in https://cs.chromium.org/chromium/src/base/test/scoped_feature_list.h?sq=package:chromium&g=0
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eac43b1c7e2a82a58412346c3885d0c5f9bbd1b commit 3eac43b1c7e2a82a58412346c3885d0c5f9bbd1b Author: Shivani Sharma <shivanisha@chromium.org> Date: Wed Jan 09 18:19:57 2019 Fix flaky test: Scoped feature list to be changed in SetUp This Cl fixes the new history intervention browser tests to not be flaky. ScopedFeatureList should only be changed in the SetUp method and not in the individual tests. Bug: 920022 Change-Id: I8b442b94fea844aba2b85b940ddfee0f65b80372 Reviewed-on: https://chromium-review.googlesource.com/c/1403178 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#621226} [modify] https://crrev.com/3eac43b1c7e2a82a58412346c3885d0c5f9bbd1b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
Comment 1 by shivanisha@google.com
, Jan 9