Support gtest perf tests in Findit - support Findit required cmd flags |
|||||
Issue description
To support gtest perf tests in Findit, test runners need to support the following cmd flags:
1. --isolated-script-test-filter=A::B::C
2. --isolated-script-test-repeat=30
a. To be consistent with currently supported test types, the exec
order should be ABCABCABC...
3. --isolated-script-test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests
Context: https://docs.google.com/document/d/1XZrAecLT33sJng9JTHsWCNpcBVU_BT7weLE76nwsTXA/edit?usp=sharing
See related issue 894254
gtest perf tests are currently supported by testing/scripts/run_gtest_perf_test.py.
,
Jan 9
Yeah, but the issue is that they have a different test runner than the other gtests, so that test runner will not be default support the new arguments.
,
Jan 9
I filed a bug 883113 for Ned to make the change to gtest perf tests. I will deduplicate it into this one.
,
Jan 9
Issue 883113 has been merged into this issue.
,
Jan 9
,
Jan 9
The bug that you merged in has another issue as well. It sounds like we also need to produce valid test results. Which test result format would you like us to support specifically? I will own this.
,
Jan 10
If we change it to the base/test/launcher/, the test results are in a format Findit can process because base/test/launcher/ takes care of that already. You may test it locally.
,
Jan 11
,
Today
(9 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237041f3346a7f29bad6bc8eb17e45de021b94e3 commit 237041f3346a7f29bad6bc8eb17e45de021b94e3 Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Jan 22 21:04:09 2019 Delete unused gtest_perf_test.py Bug: 920002 Change-Id: Ie902f4307398f4697b8d96b881734ea46db60e0e Reviewed-on: https://chromium-review.googlesource.com/c/1423675 Reviewed-by: Emily Hanley <eyaich@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#624911} [delete] https://crrev.com/0d8e9cd95d628d7b09faa11155030f6cb5b3cfe5/testing/scripts/gtest_perf_test.py
,
Today
(7 hours ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by chanli@chromium.org
, Jan 8