New issue
Advanced search Search tips

Issue 919991 link

Starred by 1 user
Status: Verified
Owner:
boliu@chromium.org
Closed: Jan 9
Cc:
fdoray@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webview_instrumentation_test_apk failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 8 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fdoray@chromium.org

webview_instrumentation_test_apk failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI

Sample failure:

Test 'org.chromium.android_webview.test.WebKitHitTestTest#testSrcAnchorTypeByFocus' had the following logs when run:

================================================================================

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.chromium.android_webview.shell/org.chromium.android_webview.test.AwTestRunnerActivity}: java.lang.RuntimeException: Cannot load WebView
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2416)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2476)
	at android.app.ActivityThread.-wrap11(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1344)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5417)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
Caused by: java.lang.RuntimeException: Cannot load WebView
	at org.chromium.android_webview.AwBrowserProcess.loadLibrary(AwBrowserProcess.java:80)
	at org.chromium.android_webview.test.AwTestRunnerActivity.onCreate(AwTestRunnerActivity.java:35)
	at android.app.Activity.performCreate(Activity.java:6251)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1107)
	at android.support.test.runner.MonitoringInstrumentation.callActivityOnCreate(MonitoringInstrumentation.java:532)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2369)
	... 9 more
Caused by: org.chromium.base.library_loader.ProcessInitException
	at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:512)
	at org.chromium.base.library_loader.LibraryLoader.loadNowOverrideApplicationContext(LibraryLoader.java:261)
	at org.chromium.base.library_loader.LibraryLoader.loadNow(LibraryLoader.java:245)
	at org.chromium.android_webview.AwBrowserProcess.loadLibrary(AwBrowserProcess.java:74)
	... 14 more
Caused by: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "_ZTIN15android_webview23CompositorFrameProducerE" referenced by "/data/app/org.chromium.android_webview.shell-1/lib/arm/libstandalonelibwebviewchromium.so"...
	at java.lang.Runtime.loadLibrary(Runtime.java:372)
	at java.lang.System.loadLibrary(System.java:1076)
	at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:481)
	... 17 more

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8924876592302435760/+/steps/webview_instrumentation_test_apk_on_Android_device_Nexus_5X/0/logs/org.chromium.android_webview.test.WebKitHitTestTest_testSrcAnchorTypeByFocus__status_FAILURE_/0

Comment 1 by fdoray@chromium.org, Jan 8

Owner: boliu@chromium.org

Comment 2 by boliu@chromium.org, Jan 8 

huh, I'm pretty sure there are bots that build component build and run these tests, what's different about this bot? what does CFI stand for..?

Comment 3 by tobiasjs@chromium.org, Jan 8 

Maybe CompositorFrameProducer::GetWeakPtr() needs to be abstract?

Comment 4 by fdoray@chromium.org, Jan 8 

We should investigate whether adding [[clang::lto_visibility_public]] to the class definition fixes the problem.

Comment 5 by boliu@chromium.org, Jan 8 

> Maybe CompositorFrameProducer::GetWeakPtr() needs to be abstract?

Oh, yeah that makes a lot more sense. holy crap that links?! magic
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9b2b7a24f5eb234b557ac09b1424d2dd25221a

commit fc9b2b7a24f5eb234b557ac09b1424d2dd25221a
Author: Bo Liu <boliu@chromium.org>
Date: Tue Jan 08 23:12:42 2019

aw: Make FrameProducer methods abstract

TBR: fdoray@chromium.org for build fix
Bug:  919991 
Change-Id: I05d5220b1b029a82949914f7d04ddf71a40fd423
Reviewed-on: https://chromium-review.googlesource.com/c/1401423
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620924}
[modify] https://crrev.com/fc9b2b7a24f5eb234b557ac09b1424d2dd25221a/android_webview/browser/compositor_frame_producer.h

Comment 7 by boliu@chromium.org, Jan 9

Status: Verified (was: Available)
There is a new failure now, so I guess that particular problem is fixed:
[0109/014407.370012:FATAL:reached_code_profiler.cc(313)] Check failed: library_process_type == PROCESS_BROWSER || library_process_type == PROCESS_CHILD.
►

Sign in to add a comment