New issue
Advanced search Search tips

Issue 919977 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Find In Page UI is dismissed after same-document navigations

Project Member Reported by eugene...@chromium.org, Jan 8 
App Version (from "Chrome Settings > About Chrome"): M73
iOS Version: All
Device: All

Steps to reproduce: 
1.) Load https://bestvpn.org/html5demos/history/
2.) Open Tools Menu and tap "Find In Page..."
3.) Tap on first link

Observed behavior: 
FIP UI is dismissed

Expected behavior: 
FIP UI should remain on the screen

Additional comments: 
Not reproducible with Desktop Chrome, Firefox on iOS, Edge on iOS.
Reproducible with Safari on iOS.

Comment 1 by eugene...@chromium.org, Jan 8 

The bug can be fixed by adding NavigationContext::IsSameDocument check to FindTabHelper::DidFinishNavigation and webState:didFinishNavigation:
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/438f9be2230005f12b7355a5affc1ec368c8fe98

commit 438f9be2230005f12b7355a5affc1ec368c8fe98
Author: Eugene But <eugenebut@google.com>
Date: Tue Jan 08 22:43:02 2019

Use DidFinishNavigation in FindTabHelper.

Deprecated NavigationItemCommitted was replaced with DidFinishNavigation.

DidFinishNavigation is called when navigation is committed, replaced or
aborted. NavigationItemCommitted is called when navigation is committed.
It's fine to dismiss FIP UI when navigation is aborted or replaced.

Bug:  781534 , 919977
Change-Id: I1d86fa6483d55c5bf71e49d5ad7f2164e2834862
Reviewed-on: https://chromium-review.googlesource.com/c/1398288
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620915}
[modify] https://crrev.com/438f9be2230005f12b7355a5affc1ec368c8fe98/ios/chrome/browser/find_in_page/find_tab_helper.h
[modify] https://crrev.com/438f9be2230005f12b7355a5affc1ec368c8fe98/ios/chrome/browser/find_in_page/find_tab_helper.mm
[modify] https://crrev.com/438f9be2230005f12b7355a5affc1ec368c8fe98/ios/chrome/browser/ui/browser_view_controller.mm
►

Sign in to add a comment