New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 919965 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Multiple leaks detect in webkit_layout_tests on WebKit Linux Trusty Leak

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fdoray@chromium.org

Builders failed on: 
- WebKit Linux Trusty Leak: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak

First failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak/28516

Unexpected Failures:
* dom/legacy_dom_conformance/xhtml/level2/html/HTMLFrameElement05.xhtml
* dom/legacy_dom_conformance/xhtml/level2/html/HTMLIFrameElement04.xhtml
* editing/deleting/5115601.html
* editing/deleting/delete_image.html
* editing/deleting/delete_selection_contains_table_row.html
* editing/execCommand/format-block-table.html
* editing/execCommand/insertNewLineInQuotedContent-outside-quote.html
* editing/execCommand/insert_paragraph/inside-div.html
* editing/execCommand/remove-list-from-range-selection.html
* editing/execCommand/switch-multiple-list-items-crash.html
* editing/inserting/insert-composition-whitespace.html
* editing/inserting/insert_between_block_quote.html
* editing/inserting/typing-around-image-001.html
* editing/selection/5131716-1.html
* editing/selection/anchor-focus2.html
* editing/selection/arrow_key_with_unfocused_selection.html
* editing/selection/character-data-mutation.html
* editing/selection/extend/extend_selection_02_rtl_backward_lineboundary.html
* editing/selection/extend/extend_selection_03_ltr_forward_character.html
* editing/selection/extend/extend_selection_03_rtl_left_word.html
* editing/selection/extend/extend_selection_05_ltr_left_word.html
* editing/selection/extend/extend_selection_05_rtl_right_character.html
* editing/selection/extend/extend_selection_06_rtl_left_lineboundary.html
* editing/selection/extend/extend_selection_07_ltr_backward_lineboundary.html
* editing/selection/extend/extend_selection_08_rtl_right_character.html
* editing/selection/extend/extend_selection_11_ltr_right_word.html
* editing/selection/extend/extend_selection_11_rtl_left_word.html
* editing/selection/extend/extend_selection_13_ltr_right_lineboundary.html
* editing/selection/extend/extend_selection_13_ltr_right_word.html
* editing/selection/extend/extend_selection_13_rtl_left_lineboundary.html
* ... 114 more (144 total) ...

Sample failure log:

09:52:02.776 30995 worker/7 dom/legacy_dom_conformance/xhtml/level2/html/HTMLIFrameElement04.xhtml leaked
09:52:02.778 30897 [3461/8581] dom/legacy_dom_conformance/xhtml/level2/html/HTMLIFrameElement04.xhtml failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveFrames":[1,2],"numberOfLiveNodes":[4,12],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,1]}))
09:52:02.777 30995 worker/7 dom/legacy_dom_conformance/xhtml/level2/html/HTMLIFrameElement04.xhtml failed:
09:52:02.777 30995 worker/7  leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveFrames":[1,2],"numberOfLiveNodes":[4,12],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,1]})

(https://chromium-swarm.appspot.com/task?id=424763b29c1db610&refresh=10&show_raw=1)

 
Owner: fdoray@chromium.org
Status: Fixed (was: Available)
The revert of "Optimise TaskQueueSelector" fixed leaks in editing/* and dom/legacy_dom_conformance/* webkit_layout_tests.

Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1401190 
Commit position: 620862

Build before: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak/28520
Build after:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak/28521
This appears to be due to inadvertent task reordering. The per_priority_starvation_tolerance_ seems to be to blame.
Curiously enough I can reproduce this problem with a ToT build if I comment out the kLowPriority queue starvation check in TaskQueueSelector::SelectWorkQueueToServiceImpl.
Cc: alexclarke@chromium.org
 Issue 919978  has been merged into this issue.

Sign in to add a comment