New issue
Advanced search Search tips

Issue 919951 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Upload MediaRecorder tests to wpt/

Project Member Reported by mcasas@chromium.org, Jan 8

Issue description

Upload whatever tests make sense from 
third_party/blink/web_tests/fast/mediarecorder/ [1]
to the wpt folder in
third_party/blink/web_tests/external/wpt/mediacapture-record/ [2]
(which is automagically upstreamed to 
third_party/blink/web_tests/external/wpt/mediacapture-record/


[1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/fast/mediarecorder/?sq=package:chromium&dr&g=0
[2] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/mediacapture-record/?q=third_party/blink/web_tests/external/wpt/mediacapture-record/&sq=package:chromium&dr
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c3b91a0d0a5f5c2cb12ef6ba9f941ac2208c56

commit 05c3b91a0d0a5f5c2cb12ef6ba9f941ac2208c56
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Jan 10 20:51:29 2019

MediaRecorder: Upstream some web_tests to WPT

This CL moves + adapts:
- MediaRecorder-detached-context.html
- MediaRecorder-creation.html
to external/wpt/mediacapture-record/ so they can be run on wpt
and its results compared across browsers (see [1]).

[1] https://wpt.fyi/results/mediacapture-record?label=stable&aligned&q=mediacapture-record

Bug: 919951
Change-Id: I3a798c753f2708c0c67b804ee42434d20532c7d4
Reviewed-on: https://chromium-review.googlesource.com/c/1400780
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621735}
[add] https://crrev.com/05c3b91a0d0a5f5c2cb12ef6ba9f941ac2208c56/third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-creation.https.html
[add] https://crrev.com/05c3b91a0d0a5f5c2cb12ef6ba9f941ac2208c56/third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-detached-context.html
[delete] https://crrev.com/30e96e5bebe7110536e23fc6d445ca6c2d55d266/third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-creation.html
[delete] https://crrev.com/30e96e5bebe7110536e23fc6d445ca6c2d55d266/third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-detached-context.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b771b2bb0f807bfdf18749f47be931e2431ff58

commit 4b771b2bb0f807bfdf18749f47be931e2431ff58
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Jan 11 20:18:33 2019

MediaRecorder: Upstream some moarrrr web_tests to WPT

This CL moves MediaRecorder-events-and-exceptions.html to the wpt/
folder, and refactors it to use canvas.captureStream() (ISO the
Chrome-specific blink_test_runner.cc thing).

It also fixes partially MediaRecorder-error.html: a new method
drawSomethingOnCanvas() is introduced and called to guarantee
that the canvas produces some captured VideoFrame, kicking the
event(s) generation. This fix is partial because Chrome doesn't
have MediaRecorderErrorEvent, but at least we verify that an
error event is thrown.

Bug: 919951
Change-Id: Ie9d7cfeeb2bf4452f4b5928eb2a7c644778751a7
Reviewed-on: https://chromium-review.googlesource.com/c/1406150
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622121}
[modify] https://crrev.com/4b771b2bb0f807bfdf18749f47be931e2431ff58/third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-error-expected.txt
[modify] https://crrev.com/4b771b2bb0f807bfdf18749f47be931e2431ff58/third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-error.html
[add] https://crrev.com/4b771b2bb0f807bfdf18749f47be931e2431ff58/third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-events-and-exceptions.html
[delete] https://crrev.com/386e185857e728e6b1ebf0d2dee60d0fdb5d317f/third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-events-and-exceptions.html

Sign in to add a comment