New issue
Advanced search Search tips

Issue 919928 link

Starred by 1 user
Status: Assigned
Owner:
mar...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Swarming: handle overly long dimensions

Project Member Reported by maruel@google.com, Jan 8 
Dimensions length is already limited to 64 characters for key and 256 characters per value.

Ref: https://cs.chromium.org/chromium/infra/luci/appengine/swarming/server/config.py

In practice in the poll flow, if a bot has more than that, the bot_event() call fails to store a BotEvent with the overly long dimensions, which leaves the bot dead and generates server side logs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/61cf826f1102ec098fca92b4b05d71dadab0ac9e

commit 61cf826f1102ec098fca92b4b05d71dadab0ac9e
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Thu Jan 10 19:14:21 2019

swarming: improve logging in poll

Print out the bot id earler to help diagnosing failures; especially with
dimensions longer than 1500 bytes, which causes a BadValueError
exception.

R=qyearsley@chromium.org

Bug: 919928
Change-Id: I86ffee675486c9acb94e297e58178867a2f058fb
Reviewed-on: https://chromium-review.googlesource.com/c/1401341
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/61cf826f1102ec098fca92b4b05d71dadab0ac9e/appengine/swarming/handlers_bot.py
►

Sign in to add a comment