New issue
Advanced search Search tips

Issue 919908 link

Starred by 1 user
Status: Assigned
Owner:
eirage@chromium.org
Cc:
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Unified Pointer Capture in Blink

Project Member Reported by eirage@chromium.org, Jan 8 
Pointer capture or mouse capture is a behavior in Blink that sends all mouse/pointer events before mouse button released to the mouse down target even if the pointer is not hovering the target (i.e. dragging). The similar logic are used in several different places.
For code health, we should have one place to do all the capturing and releasing.

design doc:
https://docs.google.com/document/d/19CIy9gMrAPEhvZSpXMGirZSPbINtLiWjMKhEGuon4FA/edit?ts=5c1c0f29#
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0495132e918d29242cb8286d1096e10607ca2ad9

commit 0495132e918d29242cb8286d1096e10607ca2ad9
Author: Ella Ge <eirage@chromium.org>
Date: Sat Jan 19 04:33:23 2019

Clean up PassMousePressToScrollbar caller

We already did a hit test on line 741 to refetch target for scrollbar,
so there is no need to check ShouldRefetchEventTarget.

This CL moves PassMousePressToScrollbar calls before the second refetch
target code to make it easier to understand. It should not change any
behavior.

Bug: 919908
Change-Id: I323a57a47868603add3399f92cadc18416c6f2fd
Reviewed-on: https://chromium-review.googlesource.com/c/1396562
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624443}
[modify] https://crrev.com/0495132e918d29242cb8286d1096e10607ca2ad9/third_party/blink/renderer/core/input/event_handler.cc
►

Sign in to add a comment