DevTools network panel "Save as..." on invalid request silently fails |
|
Issue description71.0.3578.98 (Official Build) (64-bit) Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36 What steps will reproduce the problem? (1) Open DevTools (2) Open a webpage with an invalid unicode escape sequence (attached invalid_char.htm) (3) Open network panel, right click the request to invalid_char.htm and click "Save as..." What is the expected result? A file picker appears and allows you to save invalid_char.htm to disk What happens instead? No file picker appears and no errors are shown This is happening because base::JSONParser::Parse is being called with default arguments which causes it to fail because it rejects invalid unicode code points: https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_ui_bindings.cc?l=580&rcl=9a51b3495410579db88bb6356b90f813f747fe8c A fix was proposed in this change: https://chromium-review.googlesource.com/c/chromium/src/+/1399538 The issue originally surfaced in this bug: http://crbug.com/824174 |
|
►
Sign in to add a comment |
|