WebBluetooth - Clean up HasEmptyOrInvalidFilter naming |
|
Issue descriptionFrom dcheng: This is a nit, but I think these conditions would be a bit easier to parse if they were phrased affirmatively instead of negatively, i.e. bool IsValidFilter(); bool IsValidRequestScanOptions(); bool IsValidRequestDeviceOptions(); Then below, we would write return !filters->empty() && std::all_of(filters->begin(), filters->end(), IsValidFilter); Which I think will remain a bit more understandable in the future. |
|
►
Sign in to add a comment |
|
Comment 1 by dougt@chromium.org
, Jan 12