New issue
Advanced search Search tips

Issue 919870 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebBluetooth - Clean up HasEmptyOrInvalidFilter naming

Project Member Reported by dougt@chromium.org, Jan 8

Issue description

From dcheng:

This is a nit, but I think these conditions would be a bit easier to parse if they were phrased affirmatively instead of negatively, i.e.

bool IsValidFilter();
bool IsValidRequestScanOptions();
bool IsValidRequestDeviceOptions();

Then below, we would write

return !filters->empty() && std::all_of(filters->begin(), filters->end(), IsValidFilter);

Which I think will remain a bit more understandable in the future.
 
Labels: Hotlist-GoodFirstBug

Sign in to add a comment