New issue
Advanced search Search tips

Issue 919818 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] external/wpt/css/css-lists/list-and-block-textarea-001.html fails

Project Member Reported by mstensho@chromium.org, Jan 8

Issue description

The list item marker contributes to the height of the list item somehow. Looks like we're trying to align the marker with the text inside the textarea (which has a smaller font).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4c55cbefc84f5afada51ffe774d9abbb3b9bf6

commit aa4c55cbefc84f5afada51ffe774d9abbb3b9bf6
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Jan 08 12:57:55 2019

[LayoutNG] external/wpt/css/css-lists/list-and-block-textarea-001.html fails.

TBR=cathiechen@igalia.com,kojii@chromium.org

Bug: 919818
Change-Id: I37ff5adfc57a72e01bcef0c9c9316a4e325c68ec
Reviewed-on: https://chromium-review.googlesource.com/c/1400688
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620695}
[modify] https://crrev.com/aa4c55cbefc84f5afada51ffe774d9abbb3b9bf6/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG

Cathie, is this a test you moved to wpt? Any idea?
Strange...
This is somehow related with:
textarea {
  border: 0px;
  padding: 0px;
}

I'll look into this. :)
Without the border and padding, maybe the baseline of the text inside the textarea will be sufficiently far down so that we don't need to push the textarea down to align with that of the list item marker?
#4 Yes, that is exactly the reason.

I tracked the changes:
We pushed the textarea down because we want list marker effect the line-height.
https://github.com/w3c/csswg-drafts/issues/2418
https://chromium-review.googlesource.com/c/chromium/src/+/994915/
This behavior isn't defined clearly yet.

However, the behavior of list-and-block-textarea-001.html is clear enough. The height of li should be 45px.

Maybe we could make a rule:
when marker is taller than content, it could affect line-height of li and the baseline of content. Otherwise, it shouldn't.

So what do you think about it?
IIRC, it was controversial in WG, fantasai wanted to keep the rhythm than to avoid possible overlap of markers.

Maybe, if it's not defined, move it back to fast directory and file to csswg?
Yes, https://codepen.io/kojiishi/pen/vRBBNd is controversial.

But I think list-and-block-textarea-001.html is not.
Textarea is taller than marker. If it is taller there should be no overlap issue.

Sign in to add a comment