New issue
Advanced search Search tips

Issue 919768 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Jan 9
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Flickering is seen while sliding 'minimum font size' slider using mouse.

Project Member Reported by pranja...@virtusa.com, Jan 8 
Chrome Version: 73.0.3664.3 (Official Build) cac0e5b7d469aad82d6fd21ee684caeec1c5cf46-refs/branch-heads/3664@{#5}(32/64 bit)
OS: Windows(8,8.1) OS

Steps to reproduce:
1. Launch chrome and change browser language to 'Tamil'.
2. Now navigate to 'chrome://settings/fonts' and slide 'minimum font size' slider to extreme using mouse.
3. Observe.

Actual Result  : Flickering is seen while sliding 'minimum font size' slider using mouse.
Expected Result: Flickering should not be seen while sliding 'minimum font size' slider using mouse.

This is regression issue broken in ‘M-71’ and below is other bisect info
Good build: 71.0.3564.0
Bad build : 71.0.3565.0

Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/192f116fd51a4f62d6614a420260f72a73d6f89a..7008dab90a9e725c3b2d721802ca4f7b3aa2983c					

Suspecting: https://chromium.googlesource.com/chromium/src/+/53ecd726c6d4420c25c295c3fafe95fb321f27fa

@Esmael El-Moslimany: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:The above issue is not seen on Win(7,10) , Mac (10.12.6, 10.13.1, 10.13.6, 10.14.3) and Linux(14.04 LTS)OS as it does not support browser language support.
Thank You..!!
Actual Result.mp4
1.4 MB View Download
Expected Result.mp4
1012 KB View Download

Comment 1 by aee@chromium.org, Jan 8

Status: Started (was: Assigned)

Comment 2 by aee@chromium.org, Jan 8

Labels: -Pri-1 Pri-3
The expected looks buggy. It's hard to tell what is causing the jumpiness of the slider values. I'm planning on adding a change threshold to the slider when there are discrete values to snap to. The slider will not update the value if the threshold is not met. I think a reasonable threshold is one slider value away. This may help with what's happening here.

I think a better approach might be to have a preview area of the text size and hold off updating the preference until drag end.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e27164069d505d386c20d4a02dad1e35b176300

commit 0e27164069d505d386c20d4a02dad1e35b176300
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jan 09 23:43:24 2019

WebUI: cr-slider, snap to new value after passing new value

Bug:  919768 
Change-Id: I9048b5f76594462fccc5e407ddf255151e310b52
Reviewed-on: https://chromium-review.googlesource.com/c/1401228
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621371}
[modify] https://crrev.com/0e27164069d505d386c20d4a02dad1e35b176300/chrome/test/data/webui/cr_elements/cr_slider_test.js
[modify] https://crrev.com/0e27164069d505d386c20d4a02dad1e35b176300/ui/webui/resources/cr_elements/cr_slider/cr_slider.js

Comment 4 by aee@chromium.org, Jan 9

Status: Fixed (was: Started)
►

Sign in to add a comment