New issue
Advanced search Search tips

Issue 919765 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jan 9
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
vasi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring is not seen on eye icon on save password bubble after pressing tab key.

Project Member Reported by pranja...@virtusa.com, Jan 8 
Chrome Version: 73.0.3664.3 (Official Build) cac0e5b7d469aad82d6fd21ee684caeec1c5cf46-refs/branch-heads/3664@{#5}(32/64 bit)

OS: Win(7,8,8.1,10) and Linux(14.04 LTS).

Precndition: Sign into gmail with valid username and password.

Steps to reproduce:
1. Launch chrome and navigate to gmail.com.
2. Click on key on omnibox and press tab key until focus reaches to eye icon.
3. Observe.

Actual  : Focus ring is not seen on eye icon on save password bubble after pressing tab key.
Expected: Focus ring should be seen on eye icon on save password bubble after pressing tab key.

This is regression issue broken in ‘M-73’ and soon update another bisect info
Good build: 73.0.3644.0 (Revision:617390)
Bad build : 73.0.3645.0 (Revision:617713)
Actual Result.mp4
379 KB View Download
Expected Result.mp4
480 KB View Download

Comment 1 by battre@chromium.org, Jan 8

Cc: vasi...@chromium.org

Comment 2 by pranja...@virtusa.com, Jan 8

Labels: hasbisect-per-revision
Owner: aaronhk@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 617623 (known good), but no later than 617625 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/fa532814ee43bb65b6870511f9665a8ae6e85329..fdb8c9ffdabec68a4bafa99975087026d7894ad8		

Suspect:https://chromium.googlesource.com/chromium/src/+/fdb8c9ffdabec68a4bafa99975087026d7894ad8

@aaronhk: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:The above issue is not seen on Mac (10.12.6, 10.13.1, 10.13.6, 10.14.3).
Thank You..!!

Comment 3 by vasi...@chromium.org, Jan 8

Owner: pbos@chromium.org
r617624 is the culprit.

Comment 4 by nyerramilli@chromium.org, Jan 8

Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6d577498884601b522648e2462828cfebe82cc

commit da6d577498884601b522648e2462828cfebe82cc
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jan 09 18:34:25 2019

Use focus ring for PasswordPendingView eye icon

Replaces the previous dashed focus that went away in r617624.

Bug:  chromium:919765 
Change-Id: I0b006f5796d85d80b5bb1682120acca2793f2358
Reviewed-on: https://chromium-review.googlesource.com/c/1401450
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621232}
[modify] https://crrev.com/da6d577498884601b522648e2462828cfebe82cc/chrome/browser/ui/views/passwords/password_pending_view.cc

Comment 6 by pbos@chromium.org, Jan 9

Status: Fixed (was: Assigned)

Comment 7 by pranja...@virtusa.com, Jan 10

Labels: TE-Verified-M73 TE-Verified-73.0.3667.0
Update:

Rechecked the above issue using latest canary build #73.0.3667.0 on Win(7,8,8.1,10) and Linux(14.04 LTS) and issue is fixed.Focus ring is seen on eye icon on save password bubble after pressing tab key.

Kindly refer attached screencast.

Thank You...
Canary Behaviour.mp4
369 KB View Download
►

Sign in to add a comment