BrowserWindowPropertyManagerTest.HostedApp is flaky.

Findit has detected 4 new flake occurrences of this test. List
of all flake occurrences can be found at:
https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEJyb3dzZXJXaW5kb3dQcm9wZXJ0eU1hbmFnZXJUZXN0Lkhvc3RlZEFwcAw.

Since these tests are still flaky, this issue has been moved back onto the Sheriff Bug Queue if it hasn't already.

If the result above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%3A%20BrowserWindowPropertyManagerTest.HostedApp&comment=Link%20to%20flake%20details%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEJyb3dzZXJXaW5kb3dQcm9wZXJ0eU1hbmFnZXJUZXN0Lkhvc3RlZEFwcAw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Trying to find culprit, appears to fail a lot on Windows bots.

loyso@: Is it possible that https://chromium-review.googlesource.com/c/chromium/src/+/1369554 is the culprit? I'm not familiar with the code here, but the first failure on Windows was observed in this build, and this was one of the commits: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30628

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserWindowPropertyManagerTest.HostedApp

Stack trace:

[ RUN      ] BrowserWindowPropertyManagerTest.HostedApp
[776:10048:0108/235252.635:WARNING:chrome_browser_main_win.cc(659)] Command line too long for RegisterApplicationRestart:  --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=BrowserWindowPropertyManagerTest.HostedApp --single_process --test-launcher-bot-mode --test-launcher-output="C:\b\s\w\itlatxc3\scoped_dir3172_10522\results3172_18763\test_results.xml" --test-launcher-summary-output="C:\b\s\w\iooliq1r\output.json" --user-data-dir="C:\b\s\w\itlatxc3\scoped_dir3172_10522\d3172_25215" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2,WebRTC-H264WithOpenH264FFmpeg --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank
[776:6640:0108/235252.705:WARNING:discovery_network_list_win.cc(196)] Failed to open Wlan client handle: 1062
../../chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc(123): error: Expected equality of these values:
  VT_LPWSTR
    Which is: 31
  prop_var.get().vt
    Which is: 0
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF64A89BA67+87]
	testing::internal::AssertHelper::operator= [0x00007FF64A89B5EE+78]
	BrowserWindowPropertyManagerTest_HostedApp_Test::RunTestOnMainThread [0x00007FF64A4ECDA8+2808]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF64C9CD99D+445]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF64D83CFEA+4650]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF64D83BD03+147]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF64B32B226+54]
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF64B6707AB+43]
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF64B32A00B+587]
	content::BrowserMainRunnerImpl::Initialize [0x00007FF64B32D388+104]
	content::BrowserMain [0x00007FF64B3284BC+156]
	content::RunBrowserProcessMain [0x00007FF64C56847F+111]
	content::ContentMainRunnerImpl::RunServiceManager [0x00007FF64C568F6A+762]
	content::ContentMainRunnerImpl::Run [0x00007FF64C568C3E+238]
	service_manager::Main [0x00007FF64D1AC957+551]
	content::ContentMain [0x00007FF64C5683AE+62]
	content::BrowserTestBase::SetUp [0x00007FF64C9CD6A4+1796]
	InProcessBrowserTest::SetUp [0x00007FF64C8195CD+429]

Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	wcslen [0x00007FF6505F1E03+115] (o:\fake\prefix\minkernel\crts\ucrt\src\appcrt\string\strnlen.cpp:218)
	BrowserWindowPropertyManagerTest_HostedApp_Test::RunTestOnMainThread [0x00007FF64A4ECE20+2928]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF64C9CD99D+445]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF64D83CFEA+4650]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF64D83BD03+147]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF64B32B226+54]
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF64B6707AB+43]
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF64B32A00B+587]
	content::BrowserMainRunnerImpl::Initialize [0x00007FF64B32D388+104]
	content::BrowserMain [0x00007FF64B3284BC+156]
	content::RunBrowserProcessMain [0x00007FF64C56847F+111]
	content::ContentMainRunnerImpl::RunServiceManager [0x00007FF64C568F6A+762]
	content::ContentMainRunnerImpl::Run [0x00007FF64C568C3E+238]
	service_manager::Main [0x00007FF64D1AC957+551]
	content::ContentMain [0x00007FF64C5683AE+62]
	content::BrowserTestBase::SetUp [0x00007FF64C9CD6A4+1796]
	InProcessBrowserTest::SetUp [0x00007FF64C8195CD+429]
	testing::Test::Run [0x00007FF64A8A0590+112]
	testing::TestInfo::Run [0x00007FF64A8A0F72+226]
	testing::TestCase::Run [0x00007FF64A8A14F2+258]
	testing::internal::UnitTestImpl::RunAllTests [0x00007FF64A8A8E2E+638]
	testing::UnitTest::Run [0x00007FF64A8A8AF5+165]
	base::TestSuite::Run [0x00007FF64C82D636+118]
	ChromeTestSuiteRunner::RunTestSuite [0x00007FF65059ECB8+56]
	content::LaunchTests [0x00007FF64C9E6F47+407]
	LaunchChromeTests [0x00007FF65059F142+306]
	main [0x00007FF65059EC34+132]
	__scrt_common_main_seh [0x00007FF6505C47C8+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	BaseThreadInitThunk [0x00007FFCDB532774+20]
	RtlUserThreadStart [0x00007FFCDD6F0D51+33]

Disabling test: https://chromium-review.googlesource.com/c/chromium/src/+/1403966

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70226b3e1acdb6401496286fe15c0fa935c9c76

commit b70226b3e1acdb6401496286fe15c0fa935c9c76
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jan 10 16:41:12 2019

Disable BrowserWindowPropertyManagerTest.HostedApp

No-Try: true
Tbr: bsep@chromium.org, pkasting@chromium.org, sky@chromium.org
Bug:  919760 
Change-Id: Iaabcf49be8c247153a87bb63930ca9ba55bd57b7
Reviewed-on: https://chromium-review.googlesource.com/c/1403966
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621603}
[modify] https://crrev.com/b70226b3e1acdb6401496286fe15c0fa935c9c76/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Test is disabled, so removing from sheriff queue.

My UMA histograms CL looks completely unrelated.

Assigning to pkasting@ (based on https://chromium-review.googlesource.com/c/chromium/src/+/1351870)

There is some history for this test:
https://bugs.chromium.org/p/chromium/issues/detail?id=396344

Peter, any ideas on what might trigger flakiness?