New issue
Advanced search Search tips

Issue 919747 link

Starred by 1 user
Status: Fixed
Owner:
sclit...@chromium.org
Closed: Jan 9
Cc:
rajendrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 709494



Sign in to add a comment

LazyLoad: VisibleLoadTime for frames isn't recorded when metrics recording is enabled but lazy frame loading is disabled.

Project Member Reported by sclit...@chromium.org, Jan 8 
Chrome Version: 72.0.3626.10 and on in M72 release branch, 73.0.3627.0 and on in M73+.
OS: Android

Looks like lazy frame visible load time metrics recording was inadvertently disabled for users without the LazyFrameLoading feature active in https://chromium.googlesource.com/chromium/src/+/e87ed71f689b53562e9594522fb68f707f7e245e.

Note that VisibleLoadTime for images appears to be recorded properly for users with metrics recording enabled but lazy loading disabled - this is just an issue with VisibleLoadTime for frames.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f250759e217507fbffa46428884fe51336a80e03

commit f250759e217507fbffa46428884fe51336a80e03
Author: Scott Little <sclittle@chromium.org>
Date: Wed Jan 09 22:09:42 2019

LazyLoad: Support recording frame metrics when LazyLoad setting is off.

Allow recording lazy load visible load time metrics for frames when the
LazyLoad setting is off, so long as frame visible load time metrics
recording is enabled. Instead, only gate the actual lazy loading of
frames on the value of Settings::GetLazyLoadEnabled().

Bug:  919747 
Change-Id: I7b5d5fff234a3ae0c49d2c6670da2689777adcdf
Reviewed-on: https://chromium-review.googlesource.com/c/1400341
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621314}
[modify] https://crrev.com/f250759e217507fbffa46428884fe51336a80e03/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/f250759e217507fbffa46428884fe51336a80e03/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc

Comment 2 by sclit...@chromium.org, Jan 9

Status: Fixed (was: Started)
►

Sign in to add a comment