New issue
Advanced search Search tips

Issue 919714 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

All policy tests failing

Project Member Reported by timkovich@google.com, Jan 8

Issue description

CrOS: 11536.0.0

Appears to be issue with the way policy stats are checked.

All policy tests are failing with the error:

01/07 00:11:46.557 WARNI|              test:0606| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled EvaluateException: UncaughtTypeError:
TypeError: Cannot read property 'textContent' of undefined
    at <anonymous>:21:58
    at Array.forEach (<anonymous>)
    at <anonymous>:18:36
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/policy_AllowDinosaurEasterEgg/policy_AllowDinosaurEasterEgg.py", line 57, in run_once
    self.setup_case(user_policies={self.POLICY_NAME: case})
  File "/usr/local/autotest/cros/enterprise/enterprise_policy_base.py", line 246, in setup_case
    device_policies)
  File "/usr/local/autotest/cros/enterprise/enterprise_policy_base.py", line 623, in verify_policy_stats
    stats = self._get_policy_stats_from_new_tab(keys)
  File "/usr/local/autotest/cros/enterprise/enterprise_policy_base.py", line 522, in _get_policy_stats_from_new_tab
    stats[policy_name] = self._get_policy_stats_shown(tab, policy_name)
  File "/usr/local/autotest/cros/enterprise/enterprise_policy_base.py", line 454, in _get_policy_stats_shown
    ''' % (table_index, policy_name))
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 221, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 263, in EvaluateJavaScript
    user_gesture=user_gesture)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 547, in _EvaluateJavaScript
    user_gesture)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 54, in Evaluate
    description=details.get('exception', {}).get('description'))
EvaluateException: UncaughtTypeError:
TypeError: Cannot read property 'textContent' of undefined
    at <anonymous>:21:58
    at Array.forEach (<anonymous>)
    at <anonymous>:18:36
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5d7732be9ce2489c98fd984837c5749fd0020c85

commit 5d7732be9ce2489c98fd984837c5749fd0020c85
Author: Max Timkovich <timkovich@chromium.org>
Date: Wed Jan 09 07:26:03 2019

[autotest] Fix policy check in enterprise_policy_base

DOM changes caused policy stats check to fail.

Added some better debug printing and made some attempts to fortify the
code against JavaScript evaulation exceptions.

BUG=chromium:919714
TEST=with AllowDinosaurEasterEgg and KeyboardDefaultToFunctionKeys

Change-Id: I28dab3f88cd17784eca6190234a1311672e8c741
Reviewed-on: https://chromium-review.googlesource.com/1400106
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Max Timkovich <timkovich@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>

[modify] https://crrev.com/5d7732be9ce2489c98fd984837c5749fd0020c85/client/cros/enterprise/enterprise_policy_base.py

Sign in to add a comment