New issue
Advanced search Search tips

Issue 919698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

content_browsertests failing on chromium.linux/Linux Tests (dbg)(1) (at 1 hour timeout)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of wolenetz@chromium.org

content_browsertests failing on chromium.linux/Linux Tests (dbg)(1)

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29


 
Cc: gbeaty@chromium.org
Labels: Infra-Troopers
Summary: content_browsertests failing on chromium.linux/Linux Tests (dbg)(1) (at 1 hour timeout) (was: content_browsertests failing on chromium.linux/Linux Tests (dbg)(1))
This bot is flakily exceeding 1 hour content_browsertests duration and appears to kill the tests at 1 hour, causing failure. Spot-checking recent failures and successes, failures are 1 hour long, and successes take about 55 minutes.

Infra: Can the timeout be increased for this test suite's execution on this bot?
Components: Infra>Client>Chrome
Owner: sergeybe...@chromium.org
Status: Assigned (was: Available)
Looks like content_browsertests runs on a single shard, thus taking a very long time. I'm going to increase the shard count to at least 4, and hope each shard will run about 15 min.

Generally, we do not want to increase these timeouts - we want to keep our builds running fast. In fact, we're thinking of tightening the timeouts further.

Instead, either tests should be optimized, or (if that's not possible) the shard count increased.
Shard count increase SGTM. Thank you, sergeyberezin@
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c298867dfa1bbe6168c982df169378ab2e92cb

commit 68c298867dfa1bbe6168c982df169378ab2e92cb
Author: Sergey Berezin <sergeyberezin@google.com>
Date: Wed Jan 09 16:41:15 2019

[content_browsertests] Increase shard level to 6

On most builders, content_browsertests was running with no sharding, taking
almost 1h to run, and occasionally timing out at 1h. 6-way sharding should
decrease its runtime to a comfortable ~10min.

Bug:  919698 
Change-Id: Idba405407e891fba144af38d76c8079b1311f050
Reviewed-on: https://chromium-review.googlesource.com/c/1401668
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621179}
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/chromium.win.json
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/68c298867dfa1bbe6168c982df169378ab2e92cb/testing/buildbot/tryserver.chromium.linux.json

Status: Fixed (was: Assigned)
The first build after the CL landed completed content_browsertests in 10 min: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/77059

\o/ thank you, sergeyberezin@

Sign in to add a comment