Warning that network might be monitored not shown if the current network is behind a policy defined proxy |
|
Issue descriptionThe issue 646698 introduced a warning in system menu shown when a proxy is used (https://chromium.googlesource.com/chromium/src.git/+/ab3bee6aed8f51dab8a8980baae0de0223698bf1). UIProxyConfigService::HasDefaultNetworkProxyConfigured is used to determine whether the default network is behind a proxy, and if so network system tray displays "Network may be monitored" warning. HasDefaultNetworkProxyConfigured checks proxy configuration using proxy_config::GetProxyConfigForNetwork with null user_prefs. This does not detect proxies set by: * kProxy pref in user profile prefs - i.e. proxies set by an extension, or proxy user policies * per-network ONC user policy (which is read from user prefs)
,
Jan 11
Should HasDefaultNetworkProxyConfigured() be using its profile_prefs_ member? Are you worried about a mash use case? We should have profile prefs available in (out-of-process) mash, although I don't know if this particular feature works there or not. Under SingleProcessMash profile prefs work just like they always have.
,
Jan 11
Yeah, that's the plan (to use profile_prefs_). Actually I meant to cc you an another, related bug - issue 919691 (in case we wanted to switch |profile_pref_| as active user changes)
,
Jan 12
Did you mean a different issue? 919691 is this one. Mash has the profile prefs for all users in a multiuser session. I'm not sure how network settings work in multiuser, though. I suspect they would follow the primary user, but I'm not familiar with the code.
,
Jan 12
D'oh. Yeah - different issue https://crbug.com/921100 Network config generally follow the primary user config. Proxy is a bit more complicated, config is loaded both from profile prefs (from each users), and part from shill (which will use the primary user config). Though, I think we will update this to always use the primary user config (even for proxy configs loaded from prefs). Either way, if we have all user pref services in mash, we should be fine. |
|
►
Sign in to add a comment |
|
Comment 1 by tbarzic@chromium.org
, Jan 11