Rotation member list was inaccurate for git-admin, caused issues with shift import when migration rotation to RotaNG. |
||||
Issue descriptionI'm in the process of migrating the git-admin rotation to RotaNG following the guide here: https://rota-ng.appspot.com/switchrota?name=Chrome+Infra+Git+Admin+Rotation 1. At the importing shifts step I reviewed the data on shifts to import and it all looked correct, including the remaining unscheduled shifts (5 weeks). 2. I imported the shifts 3. I clicked on 'manage' imported shifts. 4. I observed that two shifts: 1/14-21 and 1/21-1/28 were in the system but the "oncaller" entry was empty. Their information was correct when I reviewed the import. 5. I tried to manually assign the shifts to the correct people, flyboy@ and ehmaldonado@ but they didn't show up in the list of options. 6. Reviewed the rotation for modification: https://rota-ng.appspot.com/modifyrota?name=Chrome+Infra+Git+Admin+Rotation and see that neither of them are listed there as members. Observed: Imported shifts didn't have the right oncallers, I believe because the oncallers weren't in the system as members of the rotation. Expected: Members of the rotation are correct, and imported data looks like it did when it was up for review (if there was a member problem, it would have been better for it to come up before I imported the data). Notes: Since it's only two shifts (well, I'm not as concerned about past shifts but that data is probably also wrong in RotaNG?) I plan to just manually add the new members and fix the two shifts and continue with migration. But hopefully you can help figure out where things went wrong.
,
Jan 7
I notice that the next step was to verify the configuration, which included reviewing members. Perhaps that should happen before shift import?
,
Jan 7
Manually fixing members, time zones, and shifts worked. I believe I have successfully migrated the rotation.
,
Jan 8
,
Jan 8
Part of this might be b/c of changes of the JSON files since I did the import beginning of December. I'll add some information to the documentation about how to reimort a new JSON file to the documentation as. Before going full public with this migration process I'll sync up the changed JSON files too. - About the TZs, this happens when you in the JSON file is listed in "rotations_list_default". If listed in the "rotation_list_pacific" it puts members into the LA TZ.. - I'll add a note to the documentation about this. - Moving the order of import and config review makes sense. Have this list so far: - Not about JSON import/sync and how to upload a newer one. - Before opening up for everyone to try, update changed JSON configuration for not yet migrated rotations. - Add note about rotation_lists and timezones. - Change order of shift import and config review. Thx. for the feedback Andy, highly appreciated!
,
Jan 8
Hmm. Edward and Alan were definitely on the rotation in December and Aaron wasn't (and he was in the file) though there is definitely an earlier time period before I joined when the makeup was as imported. Regardless, I think you list of action items to address everything I found sounds great and like it would help address all of the (minor) pains I experienced.
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f55e0db42afd58bf74af4dbdf0c91ebf8180d0af commit f55e0db42afd58bf74af4dbdf0c91ebf8180d0af Author: Ola Karlsson <olakar@chromium.org> Date: Wed Jan 09 04:35:55 2019 [rotang] Fixing feedback from the git-admin rotation migration. Bug: 919687 Change-Id: Ia94e1971fe94f16fee07864985995f0cc85b7a4c Reviewed-on: https://chromium-review.googlesource.com/c/1401962 Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com> Commit-Queue: Ola Karlsson <olakar@chromium.org> Cr-Commit-Position: refs/heads/master@{#19850} [modify] https://crrev.com/f55e0db42afd58bf74af4dbdf0c91ebf8180d0af/go/src/infra/appengine/rotang/DOCUMENTATION.md [modify] https://crrev.com/f55e0db42afd58bf74af4dbdf0c91ebf8180d0af/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go [modify] https://crrev.com/f55e0db42afd58bf74af4dbdf0c91ebf8180d0af/go/src/infra/appengine/rotang/cmd/handlers/handle_upload.go [modify] https://crrev.com/f55e0db42afd58bf74af4dbdf0c91ebf8180d0af/go/src/infra/appengine/rotang/cmd/app/templates/pages/switchrota.html
,
Jan 9
This should now be live in the prod env. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ajp@chromium.org
, Jan 7