SmartLock.AuthResult.SignIn metric reports 100% failure rate |
||
Issue descriptionSee [1]. A quick investigation of the call hierarchy of SmartLockMetricsRecorder::RecordAuthResultSignInSuccess() shows that it only gets called in failure cases [2]. We need to actually call RecordAuthResultSignInSuccess(true) at some point :) 1) https://uma.googleplex.com/p/chrome/timeline_v2/?sid=c4036c1b85bcae968b18cf4fa6fca11f 2) https://cs.chromium.org/chromium/src/chromeos/components/proximity_auth/smart_lock_metrics_recorder.cc?q=SmartLock.AuthResult.SignIn&sq=package:chromium&g=0&l=49
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f715b679954a75ba2702c9297150f5ff409958fe commit f715b679954a75ba2702c9297150f5ff409958fe Author: Regan Hsu <hsuregan@chromium.org> Date: Thu Jan 10 19:42:06 2019 [CrOS MultiDevice] Metrics for SL AuthResult Sign-In Success added. Success case was excluded in original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1352485. Bug: 919674 Change-Id: I9e5dbc6d3115601252154592dd141426ff486d1a Reviewed-on: https://chromium-review.googlesource.com/c/1399466 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#621712} [modify] https://crrev.com/f715b679954a75ba2702c9297150f5ff409958fe/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
,
Jan 10
|
||
►
Sign in to add a comment |
||
Comment 1 by hsuregan@chromium.org
, Jan 7