New issue
Advanced search Search tips

Issue 919667 link

Starred by 1 user
Status: Fixed
Owner:
osh...@chromium.org
Closed: Jan 10
Cc:
msw@chromium.org
manucornet@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Launcher-Tech-Debt


Sign in to add a comment

remove WORKSPACE_WINDOW_STATE_WINDOW_OVERLAPS_SHELF and ignore_by_shelf flag

Project Member Reported by osh...@chromium.org, Jan 7 
Shelf no longer becomes transparent, so we can remove these code.

+manucornet/sgabriel in case there is a plan to bring it back.

Comment 1 by osh...@chromium.org, Jan 7

Components: UI>Shell>Shelf

Comment 2 by osh...@chromium.org, Jan 7

Labels: CrOSFilesCategory-CodeHealth

Comment 3 by sgabr...@chromium.org, Jan 7 

There's no plan of bringing that state back.

Comment 4 by manucornet@chromium.org, Jan 9 

Yeah I actually removed quite a bit of logic around this overlap state inside ash/shelf here:

https://chromium-review.googlesource.com/c/chromium/src/+/1384024

Further cleanup will be great :-) Thanks Oshima!

Comment 5 by osh...@chromium.org, Jan 10

Status: Fixed (was: Started)
Apparently, i forgot to add this bug number in CL.
It's removed by https://chromium-review.googlesource.com/c/chromium/src/+/1399047
►

Sign in to add a comment