New issue
Advanced search Search tips

Issue 919665 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

cellular: UI only shows IPv6 address when provisioned both IPv4 and IPv6 addresses

Project Member Reported by akhouderchah@chromium.org, Jan 7

Issue description

After enabling IPv6 support for cellular, the UI only displays the wwan interface's IPv6 address, despite the presence of an IPv4 address as well.

It seems that the IPv4 ipconfig object does not have the "method" property set, where it should be set to something like "dhcp" or "ipv4".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/534add0ed52d77124994afe0bf4ae9baefca0911

commit 534add0ed52d77124994afe0bf4ae9baefca0911
Author: Alex Khouderchah <akhouderchah@chromium.org>
Date: Wed Jan 16 20:28:59 2019

shill: cellular: Set IPConfig::Properties::method based on IPConfig::method

The networking UI code relies on the IPConfig::Properties::method
string (through DBus) in order to determine various pieces of
information about a device's IP addresses. In cellular, this string
was not being set to match the IPConfig::method value provided by
modemmanager. This change fixes that, such that the networking UI
behaves as it does in WiFi when a device has both IPv4 and v6
addresses.

BUG= chromium:919665 
TEST=Cellular IP address information displayed by the UI is now
     consistent with WiFi when the device has both IPv4 and v6
     addresses (i.e. default IP Address field shows the v4 address,
     and the network tab displays v4 address under "IP address"
     and v6 address under "IPv6 address").

Change-Id: I282e185ca71ca0777507f1bf260665af15ff21b8
Reviewed-on: https://chromium-review.googlesource.com/1405370
Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org>
Tested-by: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/534add0ed52d77124994afe0bf4ae9baefca0911/shill/cellular/cellular_bearer.cc

Comment 2 by akhouderchah@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment