Spacing added by repeat keyword 'space' causes masks to not appear when composited with source-in
Reported by
mab...@microsoft.com,
Jan 7
|
|||||
Issue descriptionChrome Version : 71.0.3578.98 (Official Build) (64-bit) (cohort: Stable) (and Canary) : 73.0.3664.0 (Official Build) canary (64-bit) (cohort: Clang-64) URLs (if applicable) : http://jsfiddle.net/5t3vbfod/5/ Other browsers tested: Firefox: OK Edge: OK What steps will reproduce the problem? (1) Open jsfiddle above What is the expected result? 6 blue circles appear What happens instead? Nothing appears Please provide any additional information below. Attach a screenshot if possible. There appears to be a difference between Canary and Release, because remove the -webkit-mask-repeat in Chrome still displays nothing, but removing it in Canary fixes the issue. It can also be reproduced using '-webkit-mask-repeat: space, repeat-y.' Changing the -webkit-mask-composite value to anything other than source-in fixes the issue.
,
Jan 8
Able to reproduce the issue on chrome reported version# 71.0.3578.98 and on latest chrome# 73.0.3664.0 with URL provided in comment# 0 using Mac 10.12.6, Windows-10 and Ubuntu 17.10. As this issue is seen from M-60(60.0.3112.0), hence considering this as Non-Regression and marking it as Untriaged. Thanks!
,
Jan 8
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189b2bc3704c10a54affb203a08469f164c8420a commit 189b2bc3704c10a54affb203a08469f164c8420a Author: Fredrik Söderquist <fs@opera.com> Date: Wed Jan 09 17:07:41 2019 Use separate PaintFlags for the spaced tile shader We would setup the tile shader using the same PaintFlags that we had (partially) set up for the actual image draw. This meant that we'd draw the shader picture using the same blend mode, which could easily end up yielding nothing. Set up a "fresh" PaintFlags for the tile shader as needed instead, using only flags relevant for the shader. Bug: 919637 Change-Id: Id141daca481ce3f90ed0c1f44c801eafcef5964b Reviewed-on: https://chromium-review.googlesource.com/c/1401045 Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#621188} [modify] https://crrev.com/189b2bc3704c10a54affb203a08469f164c8420a/third_party/blink/renderer/platform/graphics/image.cc [add] https://crrev.com/189b2bc3704c10a54affb203a08469f164c8420a/third_party/blink/web_tests/css3/masking/mask-composite-source-in-repeat-spacing-expected.html [add] https://crrev.com/189b2bc3704c10a54affb203a08469f164c8420a/third_party/blink/web_tests/css3/masking/mask-composite-source-in-repeat-spacing.html
,
Jan 9
,
Jan 11
Able to reproduce the issue on chrome reported version 71.0.3578.98(Build without fix) Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 17.10 on Chrome version #73.0.3668.0 as per the comment#0 Attaching screenshot for reference. Observed "6 blue circles appeared" Hence, the fix is working as expected. Adding the verified label. Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by susan.boorgula@chromium.org
, Jan 8