New issue
Advanced search Search tips

Issue 919621 link

Starred by 1 user
Status: Assigned
Owner:
akes...@chromium.org
Cc:
xixuan@chromium.org
ayatane@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

add serverdb-like rpc endpoints to crosskylabadmin

Project Member Reported by akes...@chromium.org, Jan 7 
Rationale: We want crosskylabadmin API to supported way to interact with our (lab and infra) inventory, rather than direct manipulation of protos.

Therefore, we'll need to add some serverdb like endpoints, such as ListServers, ModifyServer, AddServer.

Per discussion with pprabhu@, we probably want to have our own proto definitions for this surface rather than reusing the existing inventory protos (which are a storage layer implementation detail, as far as crosskylabadmin users are concerned).

Comment 1 by ayatane@chromium.org, Jan 8

Labels: Hotlist-Skylab
Status: Available (was: Untriaged)

Comment 2 by akes...@chromium.org, Jan 8

Owner: akes...@chromium.org
Status: Assigned (was: Available)
Working on a ListDrones implementation
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9f5b83bac8f87c1df45a643120351df6f6d84ce1

commit 9f5b83bac8f87c1df45a643120351df6f6d84ce1
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Jan 15 21:25:06 2019

crosskylabadmin: add ListServers stub

BUG=chromium:919621

Change-Id: I4bb910331777438c04a5410ed95f6d28261cb8d8
Reviewed-on: https://chromium-review.googlesource.com/c/1399323
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19995}
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/common.pb.go
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory.go
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.proto
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventoryserver_dec.go
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.pb.go
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.mock.pb.go
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/common.proto
[modify] https://crrev.com/9f5b83bac8f87c1df45a643120351df6f6d84ce1/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/pb.discovery.go
►

Sign in to add a comment