New issue
Advanced search Search tips

Issue 919619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[FCP++] Report Largest Content Paint to UKM & UMA

Project Member Reported by maxlg@chromium.org, Jan 7

Issue description

FCP++ has Text Paint Timing and Image Paint Timing. Each of them only report either the largest text paint or image paint. This limits them to work for the image/text intense sites. In order to improve FCP++ as a whole, we need to combine largest text paint and Largest image paint to be one metric, largest content paint.

To define the largest content paint, we take the maximum size between the largest image size and the largest text size. If the max size is on image, the largest content is the largest image. vice versa. The largest content paint is the paint time of either the largest text paint or the largest image paint, depending on which size is larger.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4acd7007e97e45d500369e6419af08c913155276

commit 4acd7007e97e45d500369e6419af08c913155276
Author: Liquan(Max) Gu <maxlg@chromium.org>
Date: Fri Jan 11 17:50:39 2019

[FCP++] Report Largest Content Paint to UKM & UMA

In order to make FCP++ deal with both text and image, we combine Largest Image
Paint and Largest Text Paint into Largest Content Paint.

The largest content paint is the paint time of either the largest text paint or
the largest image paint, depending on whether the largest text or the largest
image is larger. We take whichever larger to be the largest content and use its
paint time as Largest Content Paint.

Bug:  919619 
Change-Id: I623e0682b43b2a98ec681b3988159780ac0f7adb
Reviewed-on: https://chromium-review.googlesource.com/c/1399282
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622054}
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/4acd7007e97e45d500369e6419af08c913155276/tools/metrics/ukm/ukm.xml

Comment 2 by maxlg@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Untriaged)

Sign in to add a comment